Replace trigger_error(E_USER_ERROR) with exceptions (PHP 8.4 compatibility) #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces deprecated usages of
trigger_error(..., E_USER_ERROR)with proper exception handling.
As of PHP 8.4, E_USER_ERROR is deprecated and will be removed in a future release.
Motivation
Scope
throw new RuntimeException(...)for runtime failures (I/O, missing dirs, etc.)throw new Error(...)for programming or internal state issuesExample
Before: