Conversation
|
Some translations are really "robotic" in French. How should we do? Can we post comments and the bot will catch up with that, or do we need to push ourselves to the branch? |
|
It'll be easier to push to the branch yourself. Sadly AI is really bad at matching tone, this is a problem in all languages. I tried to adjust prompts to be a little less formal, but the results of that were even worse (different project). |
|
Rebuilding translations based on feedback in these threads sounds interesting, cleanest option is to just refine the prompt, maybe a 'Honor the tone of the original translation' might help. Automated translations sounding automated will probably never really go away, most important part is that they are up-to date and accurate. |
I can't 😕 @dunglas is there something to do on your side with the permissions? |
Signed-off-by: Marc <m@pyc.ac>
|
I seem to have
Are you sure you checked out the correct branch? We should all have permissions. |
|
Alright I don't know why Goland refused to push to upstream, but the CLI is fine with it. 🤷 |
alexandre-daubois
left a comment
alexandre-daubois
left a comment
There was a problem hiding this comment.
I humanized French translation. Approved as much as I can 🙂
|
Should we merge these translations PRs? They are starting to pile up, maybe we should just merge them now apart if someone would like to review one of the languages? |
There was a problem hiding this comment.
Pull request overview
Updates localized Docker documentation across multiple languages, aligning translations with the current upstream docs/docker.md content (tag naming, default Caddyfile note, non-root/capabilities guidance, and “Hardening Images” section).
Changes:
- Expanded/updated Docker tag description and added “How to adjust configuration” sections in several locales.
- Added/updated content for running as non-root, running without capabilities, and image hardening (distroless/hardened base images) in translated docs.
- Cleaned up some formatting/wording and removed stray BOM markers in TR/RU
config.md.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/tr/docker.md | Updates Turkish Docker guide; adds config/hardening sections and revises wording/links. |
| docs/tr/config.md | Removes BOM/formatting artifact in header line. |
| docs/ru/docker.md | Updates Russian Docker guide; adds config/hardening sections and revises examples. |
| docs/ru/config.md | Removes BOM/formatting artifact in header line. |
| docs/pt-br/docker.md | Updates Brazilian Portuguese Docker guide; aligns content with upstream and adjusts module paths. |
| docs/ja/docker.md | Updates Japanese Docker guide; adds config/hardening sections and expands OS tag list. |
| docs/fr/docker.md | Updates French Docker guide; adds config/hardening sections and revises links/wording. |
| docs/cn/docker.md | Updates Chinese Docker guide; adds config/hardening sections and revises wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@alexandre-daubois I've opened a new pull request, #2238, to work on those changes. Once the pull request is ready, I'll request review from you. |
…FR/RU/TR docker.md (#2238) Review feedback on the previous translation PR identified broken internal anchors and untranslated English comments in code blocks across three locales. ## Changes - **`docs/fr/docker.md`** - Fix broken anchor: `compile.md#using-xcaddy` → `compile.md#utiliser-xcaddy` - Fix title grammar: "Durcir la sécurité les images" → "Durcir la sécurité des images" - **`docs/ru/docker.md`** - Translate English comments in `compose.yaml` example (restart/build hints, tty note, volumes comment) - Translate English comments in non-root `Dockerfile` example (`adduser`, `setcap`, `chown` hints) - Translate English comments in no-capabilities `Dockerfile` example - Translate all English comments in the hardening section `Dockerfile` (distroless base, app copy, lib copy, php.ini, Caddy dirs, entrypoint) - **`docs/tr/docker.md`** - Fix broken anchor: `compile.md#using-xcaddy` → `compile.md#xcaddy-kullanımı` <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexandre-daubois <2144837+alexandre-daubois@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Alexandre Daubois <2144837+alexandre-daubois@users.noreply.github.com>
Translation updates for: docker.md .