Skip to content

[Sync EN] enumerations: Amend the CS of the code examples #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilDaiguille merged 1 commit into from
Jun 7, 2026
Merged

[Sync EN] enumerations: Amend the CS of the code examples #724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 47 additions & 15 deletions language/enumerations.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- EN-Revision: 1eb67bea30f61f7d9cdfd371146911a0ba07bbd2 Maintainer: lacatoire Status: ready -->
<!-- EN-Revision: 4c158f4a34c8f869a43f9f0bd5a4897fb35cec89 Maintainer: lacatoire Status: ready -->
<!-- Reviewed: no -->
<chapter xml:id="language.enumerations" xmlns="http://docbook.org/ns/docbook" annotations="interactive">
<title>Enumeraciones</title>
Expand Down Expand Up @@ -38,6 +38,7 @@
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

enum Suit
{
case Hearts;
Expand All @@ -60,6 +61,7 @@ enum Suit
<programlisting role="php">
<![CDATA[
<?php

enum Suit
{
case Hearts;
Expand Down Expand Up @@ -106,6 +108,7 @@ pick_a_card('Spades');
<programlisting role="php">
<![CDATA[
<?php

enum Suit
{
case Hearts;
Expand Down Expand Up @@ -156,6 +159,7 @@ if ($a !== 'Spades') {
<programlisting role="php">
<![CDATA[
<?php

enum Suit
{
case Hearts;
Expand Down Expand Up @@ -194,6 +198,7 @@ print Suit::Spades->name;
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

enum Suit: string
{
case Hearts = 'H';
Expand Down Expand Up @@ -236,6 +241,7 @@ enum Suit: string
<programlisting role="php">
<![CDATA[
<?php

enum Suit: string
{
case Hearts = 'H';
Expand All @@ -259,6 +265,7 @@ print Suit::Clubs->value;
<programlisting role="php">
<![CDATA[
<?php

enum Suit: string
{
case Hearts = 'H';
Expand Down Expand Up @@ -308,6 +315,7 @@ $ref = &$suit->value;
<programlisting role="php">
<![CDATA[
<?php

enum Suit: string
{
case Hearts = 'H';
Expand Down Expand Up @@ -353,6 +361,7 @@ print $suit->value . "\n";
<programlisting role="php">
<![CDATA[
<?php

interface Colorful
{
public function color(): string;
Expand All @@ -368,7 +377,7 @@ enum Suit implements Colorful
// Cumple con el contrato de la interfaz.
public function color(): string
{
return match($this) {
return match ($this) {
Suit::Hearts, Suit::Diamonds => 'Red',
Suit::Clubs, Suit::Spades => 'Black',
};
Expand Down Expand Up @@ -406,6 +415,7 @@ print Suit::Diamonds->shape(); // imprime "Rectangle"
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

interface Colorful
{
public function color(): string;
Expand All @@ -421,7 +431,7 @@ enum Suit: string implements Colorful
// Cumple con el contrato de la interfaz.
public function color(): string
{
return match($this) {
return match ($this) {
Suit::Hearts, Suit::Diamonds => 'Red',
Suit::Clubs, Suit::Spades => 'Black',
};
Expand Down Expand Up @@ -454,6 +464,7 @@ enum Suit: string implements Colorful
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

interface Colorful
{
public function color(): string;
Expand All @@ -470,7 +481,7 @@ final class Suit implements UnitEnum, Colorful

public function color(): string
{
return match($this) {
return match ($this) {
Suit::Hearts, Suit::Diamonds => 'Red',
Suit::Clubs, Suit::Spades => 'Black',
};
Expand Down Expand Up @@ -509,6 +520,7 @@ final class Suit implements UnitEnum, Colorful
<programlisting role="php">
<![CDATA[
<?php

enum Size
{
case Small;
Expand All @@ -517,7 +529,7 @@ enum Size

public static function fromLength(int $cm): self
{
return match(true) {
return match (true) {
$cm < 50 => self::Small,
$cm < 100 => self::Medium,
default => self::Large,
Expand Down Expand Up @@ -551,6 +563,7 @@ var_dump(Size::fromLength(50));
<programlisting role="php">
<![CDATA[
<?php

enum Size
{
case Small;
Expand Down Expand Up @@ -578,14 +591,16 @@ var_dump(Size::Huge);
<programlisting role="php">
<![CDATA[
<?php

interface Colorful
{
public function color(): string;
}

trait Rectangle
{
public function shape(): string {
public function shape(): string
{
return "Rectangle";
}
}
Expand All @@ -601,7 +616,7 @@ enum Suit implements Colorful

public function color(): string
{
return match($this) {
return match ($this) {
Suit::Hearts, Suit::Diamonds => 'Red',
Suit::Clubs, Suit::Spades => 'Black',
};
Expand Down Expand Up @@ -636,6 +651,7 @@ var_dump($suit->shape());
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

// Esta es una definición de Enumeración completamente legal.
enum Direction implements ArrayAccess
{
Expand Down Expand Up @@ -734,6 +750,7 @@ $foo = new Foo();
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

$clovers = new Suit();
// Error: No se puede instanciar la enumeración Suit

Expand All @@ -757,6 +774,7 @@ $horseshoes = (new ReflectionClass(Suit::class))->newInstanceWithoutConstructor(
<programlisting role="php">
<![CDATA[
<?php

enum Suit
{
case Hearts;
Expand Down Expand Up @@ -796,6 +814,7 @@ var_dump(SuitBacked::cases());
<programlisting role="php">
<![CDATA[
<?php

enum Suit: string
{
case Hearts = 'H';
Expand Down Expand Up @@ -832,11 +851,14 @@ print serialize(Suit::Hearts);
<programlisting role="php">
<![CDATA[
<?php
enum Foo {

enum Foo
{
case Bar;
}

enum Baz: int {
enum Baz: int
{
case Beep = 5;
}

Expand Down Expand Up @@ -869,12 +891,14 @@ Baz Enum:int {
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

class A {}
class B extends A {}

function foo(A $a) {}

function bar(B $b) {
function bar(B $b)
{
foo($b);
}
]]>
Expand All @@ -893,7 +917,9 @@ function bar(B $b) {
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php
enum ErrorCode {

enum ErrorCode
{
case SOMETHING_BROKE;
}

Expand All @@ -920,13 +946,16 @@ function quux(ErrorCode $errorCode)
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

// Código de experimento mental donde las enumeraciones no son finales.
// Nota: esto no funcionará realmente en PHP.
enum MoreErrorCode extends ErrorCode {
enum MoreErrorCode extends ErrorCode
{
case PEBKAC;
}

function fot(MoreErrorCode $errorCode) {
function fot(MoreErrorCode $errorCode)
{
quux($errorCode);
}

Expand Down Expand Up @@ -958,6 +987,7 @@ fot(MoreErrorCode::PEBKAC);
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php

enum SortOrder
{
case Asc;
Expand Down Expand Up @@ -987,6 +1017,7 @@ function query($fields, $filter, SortOrder $order = SortOrder::Asc)
<programlisting role="php">
<![CDATA[
<?php

enum UserStatus: string
{
case Pending = 'P';
Expand All @@ -996,7 +1027,7 @@ enum UserStatus: string

public function label(): string
{
return match($this) {
return match ($this) {
self::Pending => 'Pending',
self::Active => 'Active',
self::Suspended => 'Suspended',
Expand Down Expand Up @@ -1026,6 +1057,7 @@ var_dump($status->label());
<programlisting role="php">
<![CDATA[
<?php

enum UserStatus: string
{
case Pending = 'P';
Expand All @@ -1035,7 +1067,7 @@ enum UserStatus: string

public function label(): string
{
return match($this) {
return match ($this) {
self::Pending => 'Pending',
self::Active => 'Active',
self::Suspended => 'Suspended',
Expand Down