Phar extraction: add warning about following symlinks - #5864
Open
DanielEScherzer wants to merge 1 commit into
Open
DanielEScherzer wants to merge 1 commit into
DanielEScherzer wants to merge 1 commit into
Conversation
Add a warning to both `Phar::extractTo()` and `PharData::extractTo()` about the fact that symlinks in the target directory are followed.
lacatoire
reviewed
Sep 18, 2026
| <parameter>directory</parameter>. If there is a symlink to some other | ||
| directory, files may be extracted outside of the desired location; if | ||
| there is a symlink to a file, the target of the symlink will be | ||
| overwritten when <parameter>overwrite</parameter> is true. |
Member
There was a problem hiding this comment.
Suggested change
| overwritten when <parameter>overwrite</parameter> is true. | |
| overwritten when <parameter>overwrite</parameter> is true, or created | |
| if it does not exist, whatever the value of <parameter>overwrite</parameter>. |
lacatoire
reviewed
Sep 18, 2026
| <parameter>directory</parameter>. If there is a symlink to some other | ||
| directory, files may be extracted outside of the desired location; if | ||
| there is a symlink to a file, the target of the symlink will be | ||
| overwritten when <parameter>overwrite</parameter> is true. |
Member
There was a problem hiding this comment.
Suggested change
| overwritten when <parameter>overwrite</parameter> is true. | |
| overwritten when <parameter>overwrite</parameter> is true, or created | |
| if it does not exist, whatever the value of <parameter>overwrite</parameter>. |
lacatoire
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a warning to both
Phar::extractTo()andPharData::extractTo()about the fact that symlinks in the target directory are followed.