Conversation
A zero or negative offset keeps the current position, a positive one seeks from the start of the stream. Copying from a blocking socket stops when the stream timeout is reached, and false may be returned even though data has already been written to the destination.
lacatoire
force-pushed
the
stream-copy-to-stream-offset-timeout
branch
from
September 15, 2026 09:28
44dddeb to
95d91de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
offsetdescription didn't say that 0 (the default) keeps the current position while a positive value seeks from the start of the stream, and nothing mentioned that copying from a blocking socket stops on the stream timeout.Fixes: #2026
Fixes: #2046
Fixes: #2414