returntypewillchange.xml Add warning about future strict return type enforcement#5613
Open
mmalferov wants to merge 1 commit into
Open
returntypewillchange.xml Add warning about future strict return type enforcement#5613mmalferov wants to merge 1 commit into
mmalferov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should we not explicitly mention that internal methods will strictly enforce return types in future PHP versions?
Currently, the documentation might give developers a false sense of security, making it look like #[ReturnTypeWillChange] is a permanent fix. In reality, it only works during the tentative phase. Once PHP 9.0 drops, any remaining signature mismatches in child classes will cause a fatal error, as far as I understand.
P. S. The checks did not pass in the previous PR. And something went wrong with rebase. So I created a new Pull Request, and closed the old one:
#5608
But even now the check doesn 't work 🤷