openssl_sign()'s new $padding parameter needs to be OPENSSL_PKCS1_PSS_PADDING for PSS padding to work#5420
Open
terrafrost wants to merge 1 commit intophp:masterfrom
Open
openssl_sign()'s new $padding parameter needs to be OPENSSL_PKCS1_PSS_PADDING for PSS padding to work#5420terrafrost wants to merge 1 commit intophp:masterfrom
terrafrost wants to merge 1 commit intophp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://www.php.net/manual/en/function.openssl-sign.php PHP 8.5.0 saw the addition of a new parameter to
openssl_sign()-$padding. The documentation says, simply, "RSA PSS padding to use". From that one might think simply setting$paddingto 1 would be sufficient but it isn't - it needs to beOPENSSL_PKCS1_PSS_PADDINGfor PSS signatures to work.That said,
OPENSSL_PKCS1_PSS_PADDINGdoes not appear to be mentioned anywhere else. https://www.php.net/manual/en/openssl.padding.php doesn't seem appropriate because that's "Padding flags for asymmetric encryption". For that I suppose there are two things that could be done. Either that could be renamed "Padding flags" or a whole new page - "Padding flags for signatures" - could be created. I suppose a third option would be to addOPENSSL_PKCS1_PSS_PADDINGto https://www.php.net/manual/en/openssl.constants.other.php . That page already hasOPENSSL_ZERO_PADDINGafter all...