Upgrade to veewee/xml v4 with PHP 8.4+ minimum#15
Merged
veewee merged 3 commits intophp-soap:mainfrom Mar 27, 2026
Merged
Conversation
- Bump PHP requirement to ~8.4.0 || ~8.5.0 - Upgrade veewee/xml from ^3.4 to ^4.7 - Replace legacy DOM classes (DOMDocument, DOMElement, DOMNode, DOMXPath) with PHP 8.4 Dom\ namespace equivalents - Switch from azjezz/psl to standalone PSL packages (dict, foundation) ^6.1 - Update psalm target PHP version to 8.4 - Remove PHP 8.3 from CI matrices - Remove comparable() usage in SoapHeaderTest (incompatible with v4 canonicalize behavior)
- Bump veewee/xml to ^4.8 (ships DOM.phpstub) - Register veewee/xml DOM stub in psalm.xml - Remove all @psalm-suppress annotations (no longer needed) - Use document_element() helper in SoapEnvelopeLocator
Dom\Element::getAttribute() returns null for missing attributes, so the empty string check is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~8.4.0 || ~8.5.0(drops PHP 8.3)veewee/xmlfrom^3.4to^4.7DOM*classes with PHP 8.4Dom\namespace equivalents (DOMDocument->Dom\XMLDocument,DOMElement->Dom\Element,DOMNode->Dom\Node,DOMXPath->Dom\XPath)azjezz/pslto standalone PSL packages (php-standard-library/dict,php-standard-library/foundation)^6.1comparable()usage inSoapHeaderTestdue to v4 canonicalize behavior change with namespace prefixesTest plan