Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0301443394
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| $githubOutputWriter = new GitHubOutputWriter(); | ||
|
|
||
| $application->addCommand(new ChangelogResolveMergedVersionCommand($githubOutputWriter)); |
There was a problem hiding this comment.
This call uses Application::addCommand(), but composer.json allows symfony/console ^7.3, and that API is only available starting in Symfony 7.4. On installations that resolve to 7.3.x, the CLI will crash at startup with an undefined-method error before any command can run. Either switch these registrations to add() or raise the minimum supported console version to 7.4.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39b9f026f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return array_values(array_filter( | ||
| self::SUPPORTED_MINORS, | ||
| static fn(string $version): bool => version_compare($version, $resolved, '>='), | ||
| )); |
There was a problem hiding this comment.
Build the test matrix from the full require.php constraint, not just the inferred minimum version. At this point the matrix includes every supported minor >= the resolved lower bound, so a constraint like >=8.3 <8.5 still yields 8.5 in the matrix. Because upper bounds are ignored during resolution, workflows can run on PHP versions the package explicitly declares unsupported, causing avoidable CI failures for otherwise valid constraints.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28da75de2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (\in_array($operator, ['', '=', '==', '^', '~', '>='], true)) { | ||
| $lowerBounds[] = $normalized; |
There was a problem hiding this comment.
Composer allows hyphenated ranges like 8.3 - 8.4, but this parser treats both numbers as bare lower-bound tokens and then returns the highest one, resolving the minimum to 8.4 instead of 8.3. That causes the generated matrix to skip the actual minimum supported minor for a valid constraint, so CI can miss compatibility regressions on the lower end of the declared support window.
Useful? React with 👍 / 👎.
| try { | ||
| $payload = json_decode(file_get_contents($composerJson), true, 512, \JSON_THROW_ON_ERROR); | ||
| } catch (JsonException) { | ||
| return [null, 'composer.json could not be parsed']; |
There was a problem hiding this comment.
This code only catches JsonException, but Safe\file_get_contents() throws filesystem exceptions when composer.json exists but cannot be read (permissions, transient I/O errors). In that case the command terminates with an uncaught exception instead of following the existing fallback path used for other metadata failures, which can hard-fail workflows unexpectedly.
Useful? React with 👍 / 👎.
1 participant
Summary
fast-forward/github-actionsas a Composer-installable Symfony Console runtime.fast-forward/dev-toolswhile keeping its Composer plugin disabled in this repository so no.githubor.agentssync runs during the initial bootstrap.Testing
composer install --no-scripts --prefer-dist --no-progress --no-interactionvendor/bin/dev-tools dev-tools:standards --no-logo --no-interaction --no-ansicomposer validate --strictvendor/bin/phpunit --no-coveragefind src tests bin -type f \( -name '*.php' -o -path 'bin/fast-forward-actions' \) -print -exec php -l {} \;bin/fast-forward-actions changelog:resolve-merged-version release/v0.1.0 --github-output --output-file <tmp>bin/fast-forward-actions php:detect-project --working-dir . --github-output --output-file <tmp>bin/fast-forward-actions summary:write '## Fast Forward smoke' --summary-file <tmp>Closes #1