Skip to content

fix: disable extension auto update for VS Code Extensions#1355

Open
Ron (rjaegers) wants to merge 2 commits into
mainfrom
fix/disable-extension-auto-update
Open

fix: disable extension auto update for VS Code Extensions#1355
Ron (rjaegers) wants to merge 2 commits into
mainfrom
fix/disable-extension-auto-update

Conversation

@rjaegers

Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request updates the VS Code devcontainer metadata configuration files to improve extension management and simplify code formatting settings. The main changes are the addition of settings to disable automatic extension updates and the consolidation of formatter configuration for C/C++ files.

Extension update management:

  • Disabled automatic extension update checks and updates by adding "extensions.autoCheckUpdates": false and "extensions.autoUpdate": false to the settings section of all relevant devcontainer-metadata.json files. [1] [2] [3] [4]

Code formatting settings:

  • Simplified the C/C++ default formatter settings by merging [c] and [cpp] into a single [c][cpp] block in the C++ and embedded C++ devcontainer configs. [1] [2]

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM
  • I understand the image size delta and agree the functionality justifies it

Copilot AI review requested due to automatic review settings July 13, 2026 07:51
@rjaegers Ron (rjaegers) requested a review from a team as a code owner July 13, 2026 07:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates devcontainer metadata for the C++, embedded C++, Rust, and docs flavors to make VS Code extension behavior more reproducible by disabling automatic extension update checks/updates, and it simplifies some editor formatter configuration for C/C++.

Changes:

  • Disable VS Code extension auto-check/auto-update via extensions.autoCheckUpdates: false and extensions.autoUpdate: false in each flavor’s devcontainer-metadata.json.
  • Consolidate C/C++ formatter configuration by merging [c] and [cpp] into a single [c][cpp] block (C++ + embedded C++).
  • Minor JSON formatting normalization (e.g., clangd.arguments inline array in C++ metadata).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.devcontainer/rust/devcontainer-metadata.json Adds VS Code settings to disable extension auto-update behavior for the Rust flavor metadata.
.devcontainer/embedded-cpp/devcontainer-metadata.json Disables extension auto-updates and consolidates C/C++ formatter settings in embedded C++ metadata.
.devcontainer/docs/devcontainer-metadata.json Adds VS Code settings to disable extension auto-update behavior for the docs flavor metadata.
.devcontainer/cpp/devcontainer-metadata.json Disables extension auto-updates, consolidates C/C++ formatter settings, and normalizes clangd.arguments formatting in C++ metadata.

Comment thread .devcontainer/cpp/devcontainer-metadata.json
Comment thread .devcontainer/rust/devcontainer-metadata.json
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1355

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 75.35 MB 75.35 MB 321 B (0%) 🔽
linux/arm64 73.44 MB 73.44 MB +155 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 23 0 0 0.27s
✅ DOCKERFILE hadolint 4 0 0 0.3s
✅ JSON npm-package-json-lint yes no no 0.59s
✅ JSON prettier 37 2 0 0 0.94s
✅ JSON v8r 37 0 0 13.81s
⚠️ MARKDOWN markdownlint 13 0 1 0 1.42s
✅ MARKDOWN markdown-table-formatter 13 0 0 0 0.31s
✅ REPOSITORY checkov yes no no 28.49s
✅ REPOSITORY gitleaks yes no no 1.31s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 55.84s
⚠️ REPOSITORY osv-scanner yes 1 no 1.18s
✅ REPOSITORY secretlint yes no no 2.62s
✅ REPOSITORY syft yes no no 2.22s
✅ REPOSITORY trivy yes no no 15.07s
✅ REPOSITORY trivy-sbom yes no no 0.38s
✅ REPOSITORY trufflehog yes no no 3.84s
⚠️ SPELL lychee 105 2 0 11.55s
✅ YAML prettier 32 0 0 0 1.42s
✅ YAML v8r 32 0 0 13.27s
✅ YAML yamllint 32 0 0 1.89s

Detailed Issues

⚠️ SPELL / lychee - 2 errors
📝 Summary
---------------------
🔍 Total..........147
🔗 Unique.........123
✅ Successful.....140
⏳ Timeouts.........0
🔀 Redirected......18
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........2
⛔ Unsupported......2

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads (at 38:7) | Rejected status code: 403 Forbidden

Errors in README.md
[ERROR] https://www.sigstore.dev/ (at 147:38) | Network error: Connection reset by peer (os error 104)

Hint: Followed 18 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ MARKDOWN / markdownlint - 1 error
docs/adr/0000-record-architecture-decisions.md:30:401 error MD013/line-length Line length [Expected: 400; Actual: 520]
⚠️ REPOSITORY / osv-scanner - 1 error
Scanning dir .
Starting filesystem walk for root: /
Scanned .devcontainer/docs/requirements.txt file and found 14 packages
Scanned .devcontainer/cpp/requirements.txt file and found 20 packages
Scanned package-lock.json file and found 73 packages
Scanned test/rust/workspace/cargo/Cargo.lock file and found 1 package
Scanned test/rust/workspace/test/Cargo.lock file and found 1 package
Scanned test/rust/workspace/cortex-m/Cargo.lock file and found 20 packages
Scanned test/rust/workspace/clippy/Cargo.lock file and found 1 package
Scanned test/rust/workspace/cortex-mf/Cargo.lock file and found 20 packages
End status: 101 dirs visited, 333 inodes visited, 8 Extract calls, 66.091996ms elapsed, 66.092277ms wall time

Total 2 packages affected by 2 known vulnerabilities (0 Critical, 0 High, 0 Medium, 0 Low, 2 Unknown) from 1 ecosystem.
0 vulnerabilities can be fixed.

+-----------------------------------+------+-----------+------------+---------+---------------+------------------------------------------+
| OSV URL                           | CVSS | ECOSYSTEM | PACKAGE    | VERSION | FIXED VERSION | SOURCE                                   |
+-----------------------------------+------+-----------+------------+---------+---------------+------------------------------------------+
| https://osv.dev/RUSTSEC-2026-0110 |      | crates.io | bare-metal | 0.2.5   | --            | test/rust/workspace/cortex-m/Cargo.lock  |
| https://osv.dev/RUSTSEC-2026-0110 |      | crates.io | bare-metal | 0.2.5   | --            | test/rust/workspace/cortex-mf/Cargo.lock |
+-----------------------------------+------+-----------+------------+---------+---------------+------------------------------------------+

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-docs:edgeghcr.io/philips-software/amp-devcontainer-docs:pr-1355

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 200.13 MB 200.13 MB +404 B (+0%) 🔼
linux/arm64 196.35 MB 196.35 MB +343 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1355

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 468.82 MB 468.82 MB +135 B (+0%) 🔼
linux/arm64 419.61 MB 419.61 MB 152 B (0%) 🔽

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1355

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 372.06 MB 372.06 MB +6.49 kB (+0%) 🔼
linux/arm64 352.23 MB 352.21 MB 16.56 kB (0%) 🔽

@rjaegers Ron (rjaegers) temporarily deployed to acceptance-testing July 13, 2026 08:02 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-cpp:edgeghcr.io/philips-software/amp-devcontainer-embedded-cpp:pr-1355

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 560.44 MB 560.44 MB 2.87 kB (0%) 🔽
linux/arm64 538.89 MB 538.9 MB +10.67 kB (+0%) 🔼

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Test Results

 21 files  ±0   21 suites  ±0   18m 42s ⏱️ + 2m 5s
 44 tests ±0   44 ✅ ±0  0 💤 ±0  0 ❌ ±0 
185 runs  ±0  185 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d8b6f99. ± Comparison against base commit 152e1e7.

♻️ This comment has been updated with latest results.

Copilot AI review requested due to automatic review settings July 13, 2026 08:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

.devcontainer/embedded-cpp/devcontainer-metadata.json:16

  • This devcontainer metadata file doesn't currently disable VS Code extension auto-updates, so images built from it won't match the PR goal of disabling extension update checks/updates. Add the extensions.autoCheckUpdates and extensions.autoUpdate settings here as well.
      "settings": {
        "C_Cpp.intelliSenseEngine": "disabled",
        "clangd.arguments": [
          "--query-driver=/opt/**/arm-none-eabi-*",
          "--compile-commands-dir=${userHome}/.amp"
        ],

Comment thread test/base/integration-tests.bats Outdated
Comment thread test/base/integration-tests.bats Outdated
Comment thread .devcontainer/cpp/devcontainer-metadata.json
Comment thread .devcontainer/rust/devcontainer-metadata.json
Comment thread .devcontainer/docs/devcontainer-metadata.json
Comment thread .devcontainer/rust/devcontainer-metadata.json Outdated
Copilot AI review requested due to automatic review settings July 13, 2026 09:07
@rjaegers Ron (rjaegers) force-pushed the fix/disable-extension-auto-update branch from c8e7c55 to 2b359e4 Compare July 13, 2026 09:07
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread .devcontainer/cpp/devcontainer-metadata.json
Comment thread .devcontainer/embedded-cpp/devcontainer-metadata.json
Copilot AI review requested due to automatic review settings July 13, 2026 09:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@rjaegers Ron (rjaegers) temporarily deployed to acceptance-testing July 13, 2026 09:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants