Skip to content

Don't show status overlays as it was behaving unexpectedly #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 1 commit into from
Jan 15, 2026
+36 −31
Merged

Don't show status overlays as it was behaving unexpectedly #2596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/extensionsIntegrated/Phoenix-live-preview/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,11 @@ define(function (require, exports, module) {

$statusOverlayMessage.text(textMessage);
$statusOverlay.data("status", status);
$statusOverlay.removeClass("forced-hidden");

// @devansh - commenting this out to not show the status overlays, need to fix later
// the issue is that status overlay - conneting status was never getting removed on devices with
// slow connections or sites with heavy videos...
// $statusOverlay.removeClass("forced-hidden");
}

/**
Expand Down
61 changes: 31 additions & 30 deletions test/spec/LiveDevelopmentMultiBrowser-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,36 +343,37 @@ define(function (require, exports, module) {
await endPreviewSession();
}, 30000);

it("should show error banner if there is syntax error in html", async function () {
let savedText,
curDoc;

await awaitsForDone(SpecRunnerUtils.openProjectFiles(["simple1.html"]),
"SpecRunnerUtils.openProjectFiles simple1.html");

await waitsForLiveDevelopmentToOpen();

curDoc = DocumentManager.getCurrentDocument();
savedText = curDoc.getText();
// split file in half to and add syntax error then see if error banner shows up
const mid = Math.ceil(savedText.length / 2);
curDoc.setText(savedText.slice(0, mid));

await awaitsFor(
function isBannerVisible() {
return testWindow.$(".live-preview-status-overlay").is(":visible") &&
testWindow.$(".live-preview-status-overlay").text()
.includes(Strings.LIVE_DEV_STATUS_TIP_SYNC_ERROR);
},
"waiting for syntax error banner to appear",
5000,
50
);

curDoc.setText(savedText);

await endPreviewSession();
}, 30000);
// @devansh: commenting out this test as we are not doing status overlays for now
// it("should show error banner if there is syntax error in html", async function () {
// let savedText,
// curDoc;
//
// await awaitsForDone(SpecRunnerUtils.openProjectFiles(["simple1.html"]),
// "SpecRunnerUtils.openProjectFiles simple1.html");
//
// await waitsForLiveDevelopmentToOpen();
//
// curDoc = DocumentManager.getCurrentDocument();
// savedText = curDoc.getText();
// // split file in half to and add syntax error then see if error banner shows up
// const mid = Math.ceil(savedText.length / 2);
// curDoc.setText(savedText.slice(0, mid));
//
// await awaitsFor(
// function isBannerVisible() {
// return testWindow.$(".live-preview-status-overlay").is(":visible") &&
// testWindow.$(".live-preview-status-overlay").text()
// .includes(Strings.LIVE_DEV_STATUS_TIP_SYNC_ERROR);
// },
// "waiting for syntax error banner to appear",
// 5000,
// 50
// );
//
// curDoc.setText(savedText);
//
// await endPreviewSession();
// }, 30000);

it("should make CSS-relative URLs absolute", async function () {
var localText,
Expand Down
Loading