fix(tune): add configurable timeout - #30
Open
YIKUAIBANZI wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tune --timeoutwith the same 30-second default and Go duration syntax used by the other collection commandscollect.Options.DeadlineWhy
tunehard-coded a 30-second command context and did not register a timeout flag. In addition,gatherdid not forwardinspectFlags.timeout, so the collector could still apply its shorter fallback deadline even if the outer command budget was increased.The first commit in #28 independently contains the shared
gatherdeadline forwarding. This focused fix includes that necessary mapping becausetune --timeoutvalues above the collector fallback would otherwise remain ineffective; if #28 lands first, the overlapping line can be dropped during rebase.Verification
go test ./... -count=1go test -race ./... -count=1go vet ./...golangci-lint v2.12.2 run ./...scripts/gate.sh(isolated committed HEAD; Linux/macOS on amd64/arm64)govulncheck ./...also ran, but the local Go 1.26.3 standard library reports advisories fixed in later Go patch releases; this change adds no dependencies.Fixes #26