Skip to content

feat: support AND, OR, NOT and NULL in cross-shard HAVING - #1908

Open
murex971 wants to merge 4 commits into
murex-having-supportfrom
having-boolean
Open

murex971 wants to merge 4 commits into
murex-having-supportfrom
having-boolean

Conversation

@murex971

Copy link
Copy Markdown
Contributor

No description provided.

@murex971
murex971 added this pull request to stack #1907 October 27, 2026 16:28
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

ProjectPgDog
Branchhaving-boolean
TestbedIntel v1
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
cpu-per-txnBenchmark Result
Measure (units)
(Result Δ%)
Upper Boundary
Measure (units)
(Limit %)
pooler-v3📈 view plot
🚷 view threshold
16.99 ops/s x 1e3
(+0.00%)Baseline: 16.99 ops/s x 1e3
16.82 ops/s x 1e3
(99.00%)
📈 view plot
🚷 view threshold
40.69 units
(+0.06%)Baseline: 40.67 units
41.07 units
(99.07%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

ProjectPgDog
Branchhaving-boolean
TestbedIntel v1
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
cpu-per-txnBenchmark Result
Measure (units)
(Result Δ%)
Upper Boundary
Measure (units)
(Limit %)
lb-v3📈 view plot
🚷 view threshold
15.99 ops/s x 1e3
(+0.00%)Baseline: 15.99 ops/s x 1e3
15.83 ops/s x 1e3
(99.00%)
📈 view plot
🚷 view threshold
41.73 units
(+0.53%)Baseline: 41.51 units
41.93 units
(99.54%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

ProjectPgDog
Branchhaving-boolean
TestbedIntel v1
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
cpu-per-txnBenchmark Result
Measure (units)
(Result Δ%)
Upper Boundary
Measure (units)
(Limit %)
ctx-switches-per-txnBenchmark Result
Measure (units)
(Result Δ%)
Upper Boundary
Measure (units)
(Limit %)
sharding-w2-v3📈 view plot
🚷 view threshold
10.00 ops/s x 1e3
(-0.00%)Baseline: 10.00 ops/s x 1e3
9.90 ops/s x 1e3
(99.00%)
📈 view plot
🚷 view threshold
62.33 units
(-0.55%)Baseline: 62.68 units
63.30 units
(98.47%)
📈 view plot
🚷 view threshold
1.27 units
(+0.33%)Baseline: 1.26 units
1.30 units
(97.41%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Metal bench passed. All 150 measures within bounds.

suite throughput cpu/txn user cycles/txn user instr/txn kernel cycles/txn ctx/txn
pooler 28.4 (-0.9% ± 1.0%) 29,337 (-2.2% ± 1.4%) 35,062 (+0.0% ± 0.02%) 38,591 (+0.0% ± 1.0%)
lb 29.47 (-1.1% ± 1.1%) 31,026 (-1.5% ± 1.5%) 35,926 (+0.1% ± 0.03%) 39,581 (-0.5% ± 1.4%)
sharding-w2 52.68 (-0.8%) 68,077 (-0.3%) 72,269 (-0.0%) 60,782 (-1.3%) 1.405 (-0.0%)
sharding-w8 153,265 (-1.8%) 47.79 (+1.9%) 68,838 (+1.7%) 56,110 (-0.0%) 54,311 (+2.1%) 0.1455 (-1.5%)
Counters per txn
suite frontend stall l1i refill backend stall
pooler 15,625 (-5.3% ± 2.6%) 3,388 (-2.2% ± 1.0%) 2,403 (+7.4% ± 2.2%)
lb 16,794 (-3.9% ± 2.8%) 3,481 (-2.4% ± 1.4%) 2,610 (+6.4% ± 3.4%)
sharding-w2 39,454 (-0.5%) 5,480 (-1.1%) 6,699 (+1.4%)
sharding-w8 40,058 (+2.8%) 5,221 (+3.2%) 8,846 (-1.8%)

Microbench: all 135 measures within bounds.

  • simple_cold: 14 of 15 benches slower, median +1.2% ± 0.5%
lb flamegraph vs b17238d

lb

Open interactive for hover, zoom and search.

lb removed

Open interactive.

microbench flamegraph vs b17238d

microbench

Open interactive for hover, zoom and search.

microbench removed

Open interactive.

pooler flamegraph vs b17238d

pooler

Open interactive for hover, zoom and search.

pooler removed

Open interactive.

sharding-w2 flamegraph vs b17238d

sharding-w2

Open interactive for hover, zoom and search.

sharding-w2 removed

Open interactive.

sharding-w8 flamegraph vs b17238d

sharding-w8

Open interactive for hover, zoom and search.

sharding-w8 removed

Open interactive.

Logs

lb, microbench, pooler, sharding-w2, sharding-w8, verdict.json

Compared c7852b3 with b17238d.

@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.96403% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...frontend/router/parser/rewrite/statement/having.rs 88.52% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@murex971
murex971 removed this pull request from stack #1907 October 28, 2026 06:31
@murex971
murex971 added this pull request to stack #1912 October 28, 2026 06:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant