fix: normalize segfault - #53
Merged
Merged
Conversation
levkk
added a commit
to pgdogdev/pgdog
that referenced
this pull request
Sep 14, 2026
### Problem `pg_parse_raw::normalize` generated invalid SQL AST nodes, which caused `pg_parse_raw::deparse` to crash with a SEGSEV. Additionally, we were not running `normalize` on Postgres regression tests, which would of immediately caught this. ### Solution pgdogdev/pg_raw_parse#53 Handle the special AST nodes and run `normalize` and `deparse` on the entire Postgres regression test suite + hasura e2e test suite.
Collaborator
|
I'd rather go back to using libpg_parse's impl if the custom one has to grow to this size |
Contributor
Author
|
That's fine, maybe that's the move going forward. My main concern is stability, although performance is a close second. Is our implementation considerably faster than pg_query's? |
Collaborator
|
I don't remember the degree to which it's faster, but I know ours is faster if we're starting with an already parsed AST, slower if we're starting with a string. |
Contributor
Author
|
This would be the hot path, so maybe it's worth keeping around. Now that we run it against postgres regression and a bunch of weird ones generated by hasura, i'm pretty confident it won't at least segfault again. |
Collaborator
|
sg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
normalizegenerates a bunch of invalid SQL nodes. Fixed the issues + running normalize on hasura and Postgres regression tests.