Fix versioning: sync build.gradle in bump script#12
Merged
Conversation
…lues EAS reads versionCode/versionName from android/app/build.gradle when a native android/ directory is present, ignoring app.json. The bump script was only updating app.json, leaving build.gradle stuck at 1.1.1/13. - Update bump script to also patch build.gradle via sed after each bump - Correct stale build.gradle values from 1.1.1/13 to current 1.4.2/19 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionCode/versionNamefromandroid/app/build.gradle(notapp.json) when a nativeandroid/directory is present. The bump script was only updatingapp.json, sobuild.gradlewas stuck at1.1.1 / 13causing every EAS build to submit the wrong version.scripts/bump-version.shnow updatesbuild.gradleviasedafter each bump, keeping it in sync withapp.json.build.gradlevalues corrected from1.1.1 / 13to1.4.2 / 19.Test plan
1.4.2with versionCode19npm run bump:patchand verifybuild.gradleis updated alongsideapp.jsonandpackage.json🤖 Generated with Claude Code