Add single note post-answer quiz #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
force-pushed
the
single-note-trainer
branch
from
22283cc to
a5f9759
Compare
This is one of the methods detailed in the book for how to start training on single notes: after an identification, play one of the three notes that compose the note, and have the child identify it.
pganssle
force-pushed
the
single-note-trainer
branch
from
a5f9759 to
a56f97d
Compare
It is not yet clear what the optimal method / UI is going to be for how to run the single note mode, so I'm erring on the side of giving a lot of options for how to do it. The biggest problem with be the transition to the final stage, since there's no natural "Hey I'm at the next step" level.
This now keeps track of single-note statistics and displays it for the current session (displaying historical session data is left for a later PR).
pganssle
force-pushed
the
single-note-trainer
branch
from
a56f97d to
72342e2
Compare
Owner
Author
|
I tested this as much as I could without pushing to production. I am a bit worried that this might break if someone is in a weird state, but without spending a lot more time on this I don't think I'll find those bugs, so hopefully if this breaks someone they'll report it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the methods described in the book for how to train on single notes — after a chord identification, pick one of the three notes from the chord and have the child identify it.