Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds two documentation files: a new GitHub pull request template at Changes
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/pull_request_template.md:
- Line 27: Update the changelog checkbox link in
.github/pull_request_template.md so it no longer points to the
pgEdge/control-plane repository; replace the hardcoded URL in the line "- [ ]
[Changelog](https://github.com/pgEdge/control-plane/blob/main/docs/development/development.md#pull-requests)
entry added for user-facing behavior changes" with a generic instruction or a
relative/internal docs link (e.g., "See repository CONTRIBUTING or
docs/development for changelog entry") so contributors in pgEdge/spock are not
redirected to the control-plane repo.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 746f0d68-39da-4eb2-8045-320ba7d41c61
📒 Files selected for processing (1)
.github/pull_request_template.md
mason-sharp
force-pushed
the
task/pr-template
branch
from
f1c2d4e to
879f170
Compare
| @@ -0,0 +1,22 @@ | |||
| <!-- PR title format: follow Conventional Commits style, e.g. | |||
There was a problem hiding this comment.
I suggest adding this template to the main CLAUDE.md file, forcing Claude to use it for PR descriptions whenever needed.
| @@ -0,0 +1,3 @@ | |||
| ## Pull Requests | |||
| When creating PRs, always read and follow the template at `.github/pull_request_template.md`. | |||
| Use `--body-file .github/pull_request_template.md` with `gh pr create`, then fill in each section appropriately based on the changes. | |||
There was a problem hiding this comment.
Not sure this line is necessary: I wonder how many developers are so crazy as to allow AI to execute code on their machines, but hope not so much.
As an example, you may check the same PR for snowflake extension here: pgEdge/snowflake#37
| @@ -0,0 +1,3 @@ | |||
| ## Pull Requests | |||
| When creating PRs, always read and follow the template at `.github/pull_request_template.md`. | |||
| Use `--body-file .github/pull_request_template.md` with `gh pr create`, then fill in each section appropriately based on the changes. | |||
There was a problem hiding this comment.
Addition of this file would conflict with anyone who has their own setup locally. It would be ongoing problem when creating commits or merging etc. I suggest we add a sample file (.claude/CLAUDE.md.example) instead and also have .claude/CLAUDE.md in .gitignore.
There was a problem hiding this comment.
@rasifr ,
Please, explain how it might cause problems?
As I see it, if you're using another AI, this file will be just ignored. If you use Claude and this repo, please use the standard PR format, or change this file in your personal fork. I can imagine someone wanting a personal fork, syncing it with us, and personal Claude settings for this project. It is possible, but it seems too strange and rare a case. Anyway, they have global Claude settings, and this specific one will be triggered only when a PR is created.
3 participants
PR template to be filled out with each PR in the future.