Skip to content

[saml] Add support for configuring pkg pfSense-pkg-saml2-auth#227

Open
KevinB-rocks wants to merge 7 commits intopfsensible:masterfrom
KevinB-rocks:feat/saml-support
Open

[saml] Add support for configuring pkg pfSense-pkg-saml2-auth#227
KevinB-rocks wants to merge 7 commits intopfsensible:masterfrom
KevinB-rocks:feat/saml-support

Conversation

@KevinB-rocks
Copy link

After adding SSO through SAML with pfrest/pfSense-pkg-saml2-auth I wanted to configure the settings of the package through Ansible and this package.

I've written a suggestion on implementation, and would like to hear your thoughts and comments. Thanks.

@KevinB-rocks
Copy link
Author

Noticed the failing build pipeline, sorry for that. I've fixed the linting now.

@opoplawski
Copy link
Contributor

Thanks for working on this. My first thought is that this doesn't belong in core, especially for a non-standard package. So I think a saml2_auth repository would be in order. Would you be interested in maintaining that?

I'll try to find some time to do a proper review at some point but my time is extremely oversubscribed these days. I'm also tweaking how some of the package handling functions work so there may be changes to be made there.

@opoplawski opoplawski self-requested a review February 28, 2026 03:12
@opoplawski opoplawski added enhancement New feature or request need response Need a response from submitter labels Feb 28, 2026
@KevinB-rocks
Copy link
Author

I do understand your view that this could be suited for a separate repository. However, I don't have the time or resources to maintain such a repository now, but rather would like to share my work so others could use it, in the simplest way possible.

Could it be solved through clear distinctions in folder structure and documentation of this repo what is core and what is extended or non-standard functionality?

I'd imagine that we would have a stronger foundation if we pool the limited development resources into this project rather than split up in multiple repos that may go stale and end up in a mess if maintainers lose interest/don't have the time to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request need response Need a response from submitter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants