Skip to content

[openvpn_server] Add DCO for Plus versions#224

Open
jhamlin96 wants to merge 9 commits intopfsensible:masterfrom
JEPEL1:openvpn-add-dco
Open

[openvpn_server] Add DCO for Plus versions#224
jhamlin96 wants to merge 9 commits intopfsensible:masterfrom
JEPEL1:openvpn-add-dco

Conversation

@jhamlin96
Copy link
Contributor

  • Improves CE vs Plus version checking
  • Adds preliminary support for DCO in openvpn_server

Tested against CE 2.8.0 and Plus 25.11.

Copy link
Contributor

@opoplawski opoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission!

I'm not sure why the tests don't seem to be allowed to run, but that's something that will need to get sorted out.

Also, please add a changelog fragment.

@jhamlin96
Copy link
Contributor Author

Thanks @opoplawski, implemented your feedback. The sanity and unit tests run for me locally, not sure what you are referring to.

@opoplawski
Copy link
Contributor

Apparently since the PR was older than 30 days I could no longer approve the workflow. With the updates I was able to. One issue to resolve.

@opoplawski opoplawski added this to the 0.7.2 milestone Feb 28, 2026
@jhamlin96
Copy link
Contributor Author

Added changelog fragment and fixed one issue for tests. Thanks!

@opoplawski
Copy link
Contributor

Could you give me push permissions to JEPEL1/core ? I'd like to rebase the commits a bit. Thanks.

@jhamlin96
Copy link
Contributor Author

Do you want me to rebase against master?

@opoplawski
Copy link
Contributor

I was looking to make it look like this: master...openvpn-add-dco

I might just close this and make a PR from that. I'm used to be being able to push changes to other people's branches of this project. I'm not sure what is different here / now.

@jhamlin96
Copy link
Contributor Author

This PR is from a branch in my fork of this repository, not a branch within your repository. The end result in the commit history should still be the same?

@opoplawski
Copy link
Contributor

No, because I've re-ordered and squashed some commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants