[openvpn_server] Add DCO for Plus versions#224
[openvpn_server] Add DCO for Plus versions#224jhamlin96 wants to merge 9 commits intopfsensible:masterfrom
Conversation
cba146c to
26727ef
Compare
26727ef to
360e14f
Compare
opoplawski
left a comment
There was a problem hiding this comment.
Thanks for the submission!
I'm not sure why the tests don't seem to be allowed to run, but that's something that will need to get sorted out.
Also, please add a changelog fragment.
|
Thanks @opoplawski, implemented your feedback. The sanity and unit tests run for me locally, not sure what you are referring to. |
|
Apparently since the PR was older than 30 days I could no longer approve the workflow. With the updates I was able to. One issue to resolve. |
|
Added changelog fragment and fixed one issue for tests. Thanks! |
|
Could you give me push permissions to JEPEL1/core ? I'd like to rebase the commits a bit. Thanks. |
|
Do you want me to rebase against master? |
|
I was looking to make it look like this: master...openvpn-add-dco I might just close this and make a PR from that. I'm used to be being able to push changes to other people's branches of this project. I'm not sure what is different here / now. |
|
This PR is from a branch in my fork of this repository, not a branch within your repository. The end result in the commit history should still be the same? |
|
No, because I've re-ordered and squashed some commits. |
Tested against CE 2.8.0 and Plus 25.11.