# fix: Replace slower division and remainder with faster bit operations and addition#133
Closed
bp0002 wants to merge 1 commit intopetgraph:masterfrom
Closed
# fix: Replace slower division and remainder with faster bit operations and addition#133bp0002 wants to merge 1 commit intopetgraph:masterfrom
bp0002 wants to merge 1 commit intopetgraph:masterfrom
Conversation
james7132
reviewed
Jun 28, 2025
Collaborator
james7132
left a comment
james7132
left a comment
There was a problem hiding this comment.
Have you benchmarked this or looked at the generated assembly? At least on x86_64, the compiler already turns the division/remainder into bitshifts.
Author
Thanks, I got it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace slower division and remainder with faster bit operations and addition