Move v4 CI from AppVeyor to GitHub Actions#2919
Open
nohwnd wants to merge 5 commits into
Open
Conversation
The AppVeyor build for v4 is dead. Replace it with a GitHub Actions workflow that runs the test suite on Windows PowerShell 5.1 and PowerShell 7 (Windows and Ubuntu), using the same invocation AppVeyor used. Remove the AppVeyor, Travis and Azure DevOps configs, the Azure one depended on a self-hosted PS2/PS3 pool that no longer exists. Fix `New-TimeSpan -mi` in TestResults tests, newer PowerShell 7 added -Milliseconds so -mi became ambiguous. 🤖
GitHub Actions runners set TEMP to the 8.3 short form (C:\Users\RUNNER~1\...), but TestDrive paths resolve to the long form, so the -like comparisons against $env:TEMP never match. Expand TEMP to the long path via Scripting.FileSystemObject. 🤖
GitHub Actions runners set TEMP to the 8.3 short form (C:\Users\RUNNER~1\...), but TestDrive is created via GetTempPath which returns the long form, so the -like comparisons never match. Compare against GetTempPath, the same API TestDrive uses. 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AppVeyor build for v4 is dead, so this moves the CI to GitHub Actions. We only test on Windows PowerShell 5.1 and PowerShell 7 (Windows and Ubuntu), nothing else is guaranteed on this branch. The goal is to keep the branch releasable in case a security fix needs to ship, release itself stays the manual
release.ps1process.The workflow uses the same test invocation AppVeyor used: import
Pester.psd1from the repo root and run the suite with-ExcludeTag VersionChecks, StyleRules, Help. It also hasworkflow_dispatchso we can re-validate the branch on demand without pushing anything.Removed the dead configs:
.appveyor.yml,.travis.yml, andazure-pipelines.yml(that one depended on a self-hosted PS2/PS3 pool that no longer exists).One test fix was needed:
New-TimeSpan -miinTestResults.Tests.ps1became ambiguous because newer PowerShell 7 added-Milliseconds. Changed it to-Minutes.Verified locally on pwsh 7.5.5 (macOS): 1023 passed, 0 failed. The 5.1 and Windows legs will be verified by this PR's checks.
🤖