Repository navigation
net-gateway: time reserved DNS upstream requests - #894
Open
nikhilbirmiwal-pplx wants to merge 2 commits into
Open
nikhilbirmiwal-pplx wants to merge 2 commits into
nikhilbirmiwal-pplx wants to merge 2 commits into
Conversation
kumarpallav-pplx
approved these changes
Oct 23, 2026
nikhilbirmiwal-pplx
removed this pull request from the merge queue due to a manual request
Oct 23, 2026
nikhilbirmiwal-pplx
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New metric:
gateway.reserved_dns.upstream.request.duration_ms(distribution, tagsresolver,outcome,git_sha). Recorded inLoggingDnsHandle::send: time from handing one query to an upstream DNS-over-TLS connection to its first response or failure, including any wait for a shared reconnect.outcomeisanswered,timeout/no_response(Hickory's per-attempt timeout),busy,error, orcancelled(send dropped first, recorded viaDrop).No behavior change:
ATTEMPT_TIMEOUTstays at 4s. Tuning it is deferred until this metric shows real upstream latency.Why
The existing
gateway.reserved_dns.request.duration_msis guest-facing end-to-end time. It includes Hickory cache hits (p50 is ~0.1 ms), local AAAA answers and capacity rejections, so it can't show the actual upstream request/response time. The new metric only counts queries that go upstream, which is what a timeout value should be sized against.Notes
resolver/outcometags may need to be allowed in Datadog's tag configuration for this metric, as with the other reserved-DNS metrics.