Repository navigation
docs: drop the duplicated SubstrateKind bullet and correct substrate comments - #657
Merged
Merged
Conversation
ac-pplx
force-pushed
the
ac/substrate-docs-followups
branch
from
October 19, 2026 21:19
88bec5c to
c7e6750
Compare
…comments #611 and #602 each added the same row-decision bullet to docs/rust/space-conventions.md, so it appeared twice; keep the copy with the examples. Correct comments #602 added: - `wakes_after_failed_control_connect`: Direct's access path wakes a suspended or restoring sandbox (`DirectSubstrate::access_runtime_client`), not every "dormant" sandbox as the Kubernetes bullet defines it. - `REGISTRY_SUBSTRATE`: every registry write to `nodes`/`node_direct` binds it and `verify` proceeds only for a live node of it; the registry's reads, and the template pull and delete routes, act on nodes of every substrate. - The registry's `substrate_scope` test module header, which said the registry reads only Direct nodes, now describes what it tests: writes and `verify`.
ac-pplx
force-pushed
the
ac/substrate-docs-followups
branch
from
October 19, 2026 21:20
c7e6750 to
ac104da
Compare
ac-pplx
marked this pull request as ready for review
October 19, 2026 21:45
ac-pplx
changed the title
mabdelraouf-pplx
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs and comments only; no code or behaviour change.
docs/rust/space-conventions.md, and both merged textually, so the bullet appeared twice. This keeps the copy with the examples (proves_execution_absence,REGISTRY_SUBSTRATE).SubstrateKind::wakes_after_failed_control_connect(common/core/src/types/node.rs): the Space bullet said Direct wakes "a dormant sandbox" on the access path, but the Kubernetes bullet above defines dormant as "suspended, or created and never started", andDirectSubstrate::access_runtime_clientwakes onlySuspended | Restoringrows. It now says "a suspended or restoring sandbox".REGISTRY_SUBSTRATE(routes/admin/node_maintenance.rs): "every registry statement scopes to it" overstated it;fetch_node/fetch_nodesread nodes of every substrate. It now says every registry write tonodes/node_directbinds it andverifyproceeds only for a live node of it, while the reads and the template pull and delete routes (node_maintenance/node_templates.rs, which load the node withfetch_node) act on nodes of every substrate. The registry'ssubstrate_scopetest module header ("reads and writes only Direct nodes") now describes what the module tests: writes andverify.The last two were raised in review on #602 after it was approved.
Validation: documentation and comment changes only, so no workspace checks per the repository's validation rules; the pre-commit hook passed.
🤖 Generated with Claude Code