Skip to content

Conversation

@tallpsmith
Copy link
Contributor

Addresses #2308

This PR systematically updates historical macOS naming references throughout the codebase:

Changes:

  • Build system: Rename macosxmacos in build identifiers and template variables
  • Legacy cleanup: Remove obsolete cocoa distribution references
  • QA tests: Update "Mac OS X" → "macOS" in test comments and scripts
  • Installer: Update user-facing error message to use "macOS"
  • Source code: Update platform comments from "MacOSX" → "macOS"

Excluded:

  • CHANGELOG (historical document)
  • vendor/ (third-party code)
  • Actual Apple SDK paths (e.g., MacOSX.platform)

Systematically rename internal build identifiers from 'macosx' to 'macos'
for consistency with modern macOS naming conventions.

Changes:
- configure.ac: target_distro=macos
- builddefs.in: PACKAGE_DISTRIBUTION checks
- build-installer: MACOS_VERSION variable and template substitution
- installer-info: @macos_version@ template variable
Remove obsolete 'cocoa' distribution checks from build conditionals.
This legacy identifier is no longer set or used.
Replace historical "Mac OS X" references with "macOS" throughout
QA test suite comments, scripts, and configuration files.
Change "MacOS X" to "macOS" in the installer requirement message
that users see when installing PCP.
Replace "MacOSX" with "macOS" in platform-specific code comments.
@tallpsmith tallpsmith added the macOS For issues specific or related to macOS label Dec 5, 2025
Copy link
Member

@kmcdonell kmcdonell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's just get this merged.

@kmcdonell kmcdonell merged commit 3d6c47a into performancecopilot:main Jan 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macOS For issues specific or related to macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants