-
Notifications
You must be signed in to change notification settings - Fork 4
Add Robot Framework support via PercyLibrary #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
neha-sanse
wants to merge
13
commits into
master
Choose a base branch
from
feature/robot-framework-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
642906c
Add Robot Framework support via PercyLibrary
neha-sanse 7c762d7
Add Robot Framework section to README and dev deps
neha-sanse 61cafd3
Add Robot Framework integration test suite
neha-sanse 5c86c43
Fix lint: replace em dashes in .robot, ignore .robot files and import…
neha-sanse a0c120f
Fix create_region kwargs to match camelCase signature
neha-sanse 1464514
Fix lint: top-level imports, remove unused imports in test file
neha-sanse cd2a3e0
Fix all remaining lint: line length, too-many-arguments, too-few-publ…
neha-sanse e7e9776
Fix labels: join list to comma-separated string before passing to per…
neha-sanse 80787d0
Fix padding: convert int to {top,bottom,left,right} object per Percy …
neha-sanse 91d3c6e
Add Create Percy Region usage examples to keyword docstrings
neha-sanse 800ddc2
Fix Robot Framework builds showing selenium instead of robotframework…
neha-sanse f024f45
Fix lint: import order and line-too-long in docstrings
neha-sanse a277854
chore: bump version to 2.2.0 for Robot Framework support
neha-sanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| httpretty==1.0.* | ||
| pylint==2.* | ||
| twine | ||
| robotframework>=5.0 | ||
| robotframework-seleniumlibrary>=5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOW — Globally disabling
import-erroris too broadThis suppresses legitimate import errors across the entire codebase, not just for the optional
robotframeworkimports. The Robot-specific imports are already wrapped intry/except ImportErrorin the code.Consider using targeted inline disables instead:
Or scope it to the specific file only.