PER-8973 feat: carry per-snapshot Storybook story metadata to the API - #2374
Open
Shivanshu-07 wants to merge 1 commit into
Open
PER-8973 feat: carry per-snapshot Storybook story metadata to the API#2374Shivanshu-07 wants to merge 1 commit into
Shivanshu-07 wants to merge 1 commit into
Conversation
Adds an optional snapshot property storybook {id, args, globals} to the
snapshot schema (so SDK-attached story identity survives validation) and
sends it as a snapshot attribute from client.createSnapshot. Attached by
@percy/storybook so the review UI can deep-link the hosted bundle to the
exact captured variant.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storybook {id, args, globals}property to the snapshot schema (/snapshot#/$defs/common) so SDK-attached story identity survives/snapshotand/snapshot/domvalidation instead of being scrubbed as an unknown propertyclient.createSnapshotforwards it as astorybooksnapshot attributeAttached by
@percy/storybook(companion SDK change) and persisted by percy-api (percy/percy-api#6506) so the review UI can deep-link the hosted Storybook bundle to the exact captured variant — includingargs/globalsstate likeargs=primary:!false.Testing
packages/clientpayload test extended with the new attribute; remaining exact-body assertions updated for thestorybook: nulldefault/snapshot/dom, invalid shapes are scrubbed🤖 Generated with Claude Code