ci: set ignore-scripts=false to fix executable build#2300
Open
pranavz28 wants to merge 1 commit into
Open
Conversation
The release-automation .npmrc set `ignore-scripts=true`. On the Build Executables runner (Node 14 / npm 6), npm honors ignore-scripts even for explicit `npm run`, so `npm run build_cjs` became a silent no-op: `build/` was never produced and `cp -R ./build/* packages/` failed with "No such file or directory". This has broken the executable build for the last 3 releases (since v1.32.0-beta.8). `yarn build` (lerna+nx) is unaffected because nx runs package scripts through its own task runner rather than `npm run`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Build Executables workflow has failed for the last 3 releases (since
v1.32.0-beta.8), most recently on v1.32.0. The job dies inscripts/executable.shat:Root cause
The release-automation PR added a root
.npmrcwithignore-scripts=true. The Build Executables runner uses Node 14 → npm 6, and npm 6 honorsignore-scriptseven for explicitnpm run <script>(npm 7+ later relaxed this). Sonpm run build_cjs(BABEL_ENV=dev babel packages -d build) became a silent no-op —build/was never created — and the followingcp -R ./build/* packages/failed.yarn buildtwo lines earlier is unaffected because it runs vialerna+ Nx, whose task runner executes package scripts directly rather than throughnpm run.Verified by elimination: same runner image, same Node version, and the exact
v1.32.0source tree all buildbuild_cjsfine; the only delta at the first failing tag was this.npmrc.Fix
Set
ignore-scripts=falsesonpm run build_cjsexecutes on the npm-6 runner.🤖 Generated with Claude Code