Skip to content

security: stop leaking signing secrets via shell interpolation / argv (PER-8611, PER-8612) #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shivanshu-07 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −2
Open

security: stop leaking signing secrets via shell interpolation / argv (PER-8611, PER-8612) #2281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/executable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,16 @@ jobs:
env:
CERT_B64: ${{ secrets.WIN_CODESIGN_CERT_CHAIN_B64 }}
- name: Sign binary with Google Cloud KMS
env:
# Bind the secret to an env var instead of interpolating it into the
# PowerShell command string, so GitHub's log redaction applies to it
# in all (incl. error) output (CWE-532).
GCP_KMS_KEY_PATH: ${{ secrets.GCP_KMS_KEY_PATH }}
run: |
$env:GOOGLE_APPLICATION_CREDENTIALS = "$PWD\gcp-sa-key.json"
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits" -Filter signtool.exe -Recurse | Where-Object { $_.FullName -match "x64" } | Select-Object -First 1
Write-Host "Using signtool: $($signtool.FullName)"
& $signtool.FullName sign /fd sha256 /tr http://timestamp.sectigo.com /td sha256 /f comodo_signing_cert.crt /csp "Google Cloud KMS Provider" /kc "${{ secrets.GCP_KMS_KEY_PATH }}" percy.exe
& $signtool.FullName sign /fd sha256 /tr http://timestamp.sectigo.com /td sha256 /f comodo_signing_cert.crt /csp "Google Cloud KMS Provider" /kc "$env:GCP_KMS_KEY_PATH" percy.exe
if ($LASTEXITCODE -ne 0) { Write-Error "Code signing failed!"; exit 1 }
Write-Host "Code signing succeeded."
& $signtool.FullName verify /pa /v percy.exe
Expand Down
5 changes: 4 additions & 1 deletion scripts/executable.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ zip percy-linux.zip percy
mv percy-osx percy
zip percy-osx.zip percy

xcrun notarytool submit --apple-id "$APPLE_ID_USERNAME" --password $APPLE_ID_KEY --team-id $APPLE_TEAM_ID percy-osx.zip --wait
# Read the Apple app-specific password from the environment via notarytool's
# `@env:` prefix instead of passing it as a CLI argument, so it is not visible
# in the process table / `ps aux` (CWE-214).
xcrun notarytool submit --apple-id "$APPLE_ID_USERNAME" --password "@env:APPLE_ID_KEY" --team-id "$APPLE_TEAM_ID" percy-osx.zip --wait

cleanup
Loading