Repository navigation
PBM-1695: Document multiple storage TLS certificates - #409
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation is consistent, technically sound, and preserves valid links and warnings.
Review effort: Balanced
Findings: None
What changed in this PR
Documents how PBM trusts certificates for multiple custom storage services.
Changes:
- Documents
SSL_CERT_FILEbundles andSSL_CERT_DIR. - Adds shell and systemd configuration steps.
- Corrects the agent restart command.
| File | Description |
|---|---|
docs/details/minio.md |
Updates MinIO certificate trust guidance. |
docs/details/s3-storage.md |
Updates S3-compatible storage certificate guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nastena1606
temporarily deployed
to
PBM-1695-multiple-storage-tls-certificates - pbm-docs-preview PR #409
October 6, 2026 08:14 — with
Render
Destroyed
rasika-chivate
marked this pull request as ready for review
October 6, 2026 08:15
rasika-chivate
requested review from
boris-ilijic and
olexandr-havryliak
and
a balanced review from Copilot
October 6, 2026 08:16
jcechace
approved these changes
Oct 6, 2026
olexandr-havryliak
approved these changes
Oct 6, 2026
boris-ilijic
approved these changes
Oct 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents certificate trust for multiple custom storage services in the PBM 2.17.0 docs. Users can point
SSL_CERT_DIRto a directory of PEM certificate files or useSSL_CERT_FILEwith a certificate bundle. The instructions cover each host running the agent or CLI, system root certificates, and configuring the environment of a systemd-managed agent.This documents existing behavior confirmed in the ticket. It does not claim that support first appeared in 2.17.0. Jira has no fix version set, and no implementation PR was found or linked.
Changed files and placement
docs/details/minio.md: updates Data upload to storage with self-signed TLS certificates → Usage example.docs/details/s3-storage.md: updates the matching section to keep both storage guides consistent.Preserves existing section anchors, navigation and TLS warnings. Both pages already appear in
mkdocs-base.yml; no new page or section is needed. Links to storage profiles, agent environment configuration, PBM logs and upstream Go certificate loading.Claim-to-source map
docs/install/configure-authentication.md, Set the MongoDB connection URI for pbm-agent, including theEnvironmentFileunit setting and platform-specific pathsdocs/install/secure-credentials-systemd.md,sudo systemctl restart pbm-agent; fixes the prior example that said restart but ran start/etc/ssl/minio-ca.crtexample and the ticket's directory approach; not fixed product defaultsValidation
MkDocs build and
git diff --checkpassed. Verified both rendered page TOCs, numbered steps, code blocks, existing TLS warnings and new internal links. Existing unrelated link warnings remain. Examples were reviewed against the sources; no live deployments were changed.