Bugfix/showpopover error#141
Open
maaso wants to merge 1 commit into
Open
Conversation
maaso
force-pushed
the
bugfix/showpopover-error
branch
from
July 9, 2026 14:17
001fae0 to
5fa99ca
Compare
glenstaes
requested changes
Jul 15, 2026
| hostDirectives: [CdkDrag] | ||
| }) | ||
| export class DraggableDialogDirective implements OnInit { | ||
| rootElementSelector = input('mat-dialog-container', { |
| hostDirectives: [CdkDrag] | ||
| }) | ||
| export class DraggableDialogDirective implements OnInit { | ||
| rootElementSelector = input('mat-dialog-container', { |
Member
There was a problem hiding this comment.
Shouldn't this be '.cdk-overlay-pane' to be backwards compatible?
Member
There was a problem hiding this comment.
Maybe we also want some global provider for setting the application default for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the default cdkDrag rootElement and make it configurable
Closes #140