Skip to content

fix(ruleset): resolve contradictory and duplicate rule declarations #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pekral merged 1 commit into from
Nov 12, 2026
Merged

fix(ruleset): resolve contradictory and duplicate rule declarations #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ All notable changes to this project will be documented in this file.
- Minimum required PHP version lowered to 8.4 — `composer.json` now requires `php: ^8.4` (before: `^8.5`). The ruleset and the build tooling use no PHP 8.5 feature.
- CI runs every check (tests, PHPCS, PHPStan, Rector, unused-sniffs) on PHP 8.4 and 8.5 again.

### Fixed
- `DisallowMultiConstantDefinition` and `DisallowMultiPropertyDefinition` are no longer listed as excluded while enabled; both stay enabled (#66).
- `ForbiddenPublicProperty` is declared once, with all four path exclusions (#66).

## [0.5.0] - 2026-06-29
### Changed
- **BREAKING: Minimum required PHP version raised to 8.5** — `composer.json` now requires `php: ^8.5`. Projects still on PHP 8.4 should stay on the 0.4.x line.
Expand Down
8 changes: 2 additions & 6 deletions ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
<!-- Ignore for Laravel projects -->
<exclude-pattern>app/Livewire/**</exclude-pattern>
<exclude-pattern>app/Models/**</exclude-pattern>
<exclude-pattern>*/Livewire/**/*.php</exclude-pattern>
<exclude-pattern>*/Models/**/*.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.Classes.BackedEnumTypeSpacing" />
<rule ref="SlevomatCodingStandard.Classes.ClassConstantVisibility" />
Expand All @@ -59,10 +61,6 @@
<rule ref="SlevomatCodingStandard.Classes.DisallowStringExpressionPropertyFetch" />
<rule ref="SlevomatCodingStandard.Classes.EmptyLinesAroundClassBraces" />
<rule ref="SlevomatCodingStandard.Classes.EnumCaseSpacing" />
<rule ref="SlevomatCodingStandard.Classes.ForbiddenPublicProperty">
<exclude-pattern>*/Livewire/**/*.php</exclude-pattern>
<exclude-pattern>*/Models/**/*.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.Classes.MethodSpacing" />
<rule ref="SlevomatCodingStandard.Classes.ModernClassNameReference" />
<rule ref="SlevomatCodingStandard.Classes.ParentCallSpacing" />
Expand All @@ -88,8 +86,6 @@
<rule ref="SlevomatCodingStandard.Classes.TraitUseDeclaration" />
<rule ref="SlevomatCodingStandard.Classes.TraitUseSpacing" />
<rule ref="SlevomatCodingStandard.Classes.UselessLateStaticBinding" />
<exclude name="SlevomatCodingStandard.Classes.DisallowMultiConstantDefinition" />
<exclude name="SlevomatCodingStandard.Classes.DisallowMultiPropertyDefinition" />
<exclude name="SlevomatCodingStandard.Classes.DisallowConstructorPropertyPromotion" />
<exclude name="SlevomatCodingStandard.Classes.UnsupportedClassGroupException" />
<exclude name="SlevomatCodingStandard.Classes.AbstractMethodSignature" />
Expand Down
Loading