fix: upgrade pcore-pconnect-typedefs to version 5.1.0

CODE_OF_CONDUCT.md

@@ -60,7 +60,7 @@ representative at an online or offline event.
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
 reported to the community leaders responsible for enforcement at
-john.arnold@pega.com.
+opensource@pega.com and security@pega.com.
 All complaints will be reviewed and investigated promptly and fairly.
 
 All community leaders are obligated to respect the privacy and security of the

package.json

@@ -104,16 +104,16 @@
     "@angular/language-service": "^21.2.4",
     "@commitlint/cli": "^21.2.3",
     "@commitlint/config-conventional": "^21.2.3",
+    "@eslint/js": "^10.0.1",
     "@pega/constellationjs": "~26.1.0",
-    "@pega/pcore-pconnect-typedefs": "4.1.0",
+    "@pega/pcore-pconnect-typedefs": "^5.1.1",
     "@playwright/test": "^1.63.0",
     "@types/jasmine": "~6.0.0",
     "@types/jasminewd2": "~2.0.13",
     "@types/node": "^24.0.0",
     "brotli": "^1.3.3",
     "compressing": "^2.1.3",
     "copy-webpack-plugin": "^14.0.0",
-    "@eslint/js": "^10.0.1",
     "eslint": "^10.11.0",
     "eslint-plugin-jest": "^29.16.6",
     "eslint-plugin-sonarjs": "^4.2.2",

packages/angular-sdk-components/src/lib/_components/infra/navbar/navbar.component.ts

@@ -34,7 +34,7 @@ export class NavbarComponent implements OnInit, OnDestroy {
   bShowCaseTypes$ = false;
 
   portalApp$: string | undefined = '';
-  portalLogoImage$: string;
+  portalLogoImage$: string | Blob | null;
   showAppName$?: boolean = false;
 
   portalOperator$: string | undefined;
@@ -110,7 +110,6 @@ export class NavbarComponent implements OnInit, OnDestroy {
 
     // making a copy, so can add info
     this.navPages$ = JSON.parse(JSON.stringify(this.pages$));
-    // @ts-ignore
     const localeReference = PCore.getLocaleUtils().getPortalLocaleReference() || this.pConn$.getValue('.pyLocaleReference');
     this.navPages$.forEach(page => {
       const destinationObject: any = {};

packages/angular-sdk-components/src/lib/_components/infra/reference/reference.component.ts

@@ -88,8 +88,7 @@ export class ReferenceComponent implements OnInit, OnDestroy, OnChanges {
       }
     };
 
-    // @ts-expect-error - createComponent expects string but null is passed for unused parameters (matches React SDK pattern)
-    const viewComponent: any = pConnect.createComponent(viewObject, null, null, {
+    const viewComponent: any = pConnect.createComponent(viewObject, '', 0, {
       pageReference: context && context.startsWith('@CLASS') ? '' : context
     });
 

packages/angular-sdk-components/src/lib/_components/template/advanced-search/advanced-search.component.ts

@@ -71,7 +71,6 @@ export class AdvancedSearchComponent implements OnInit, OnChanges {
     const [firstChildMeta] = rawViewMetadata.children;
 
     const localizedVal = PCore.getLocaleUtils().getLocaleValue;
-    // @ts-ignore
     const cache = PCore.getNavigationUtils().getComponentCache(searchSelectCacheKey) ?? {};
 
     this.editableFieldComp = firstChildPConnect().createComponent({

packages/angular-sdk-components/src/lib/_components/template/advanced-search/search-groups/search-groups.component.ts

@@ -210,8 +210,7 @@ export class SearchGroupsComponent implements OnInit, OnDestroy, OnChanges {
       isValidInput(formValues)
     ) {
       if (this.isValidatorField) {
-        // @ts-ignore
-        PCore.getMessageManager().clearContextMessages({ context: transientItemID });
+        PCore.getMessageManager().clearContextMessages({ context: this.transientItemID });
       }
 
       this.previousFormValues = formValues;

packages/angular-sdk-components/src/lib/_components/template/app-shell/app-shell.component.ts

@@ -52,7 +52,7 @@ export class AppShellComponent implements OnInit, OnDestroy {
   bOkDisplayError = false;
   portalTemplate: string;
   links: any = [];
-  imageURL: string | Blob;
+  imageURL: string | Blob | null;
   localizedVal = PCore.getLocaleUtils().getLocaleValue;
 
   constructor(
@@ -89,7 +89,6 @@ export class AppShellComponent implements OnInit, OnDestroy {
       PCore.getEnvironmentInfo().setEnvironmentInfo({ ...PCore.getEnvironmentInfo().environmentInfoObject, pyPortalTemplate: 'wss' } as any);
     }
 
-    // @ts-ignore - Property 'pyCaseTypesAvailableToCreateDP' does not exist on type pxApplication
     const caseTypesAvailableToCreateDP = PCore.getEnvironmentInfo().environmentInfoObject?.pxApplication?.pyCaseTypesAvailableToCreateDP;
     if (caseTypesAvailableToCreateDP) {
       const portalID = this.pConn$.getValue('.pyOwner');

packages/angular-sdk-components/src/lib/_components/template/data-reference/data-reference.component.ts

@@ -152,8 +152,7 @@ export class DataReferenceComponent implements OnInit, OnDestroy {
     this.isDisplayModeEnabled = ['DISPLAY_ONLY', 'STACKED_LARGE_VAL'].includes(displayMode);
     this.refFieldMetadata = this.pConn$.getFieldMetadata(this.rawViewMetadata?.config?.authorContext);
     this.pyID = getMappedKey('pyID');
-    // @ts-ignore
-    const { allowImplicitRefresh } = PCore.getFieldDefaultUtils().fieldDefaults?.DataReference || {};
+    const { allowImplicitRefresh } = PCore.getFieldDefaultUtils().fieldDefaults?.['DataReference'] || {};
 
     this.allowImplicitRefresh = allowImplicitRefresh;
     this.isDDSourceDeferred =
@@ -398,7 +397,6 @@ export class DataReferenceComponent implements OnInit, OnDestroy {
     if (['Dropdown', 'Checkbox', 'RadioButtons'].includes(type) && !config.deferDatasource && config.datasource) {
       const isCardVariant = config.variant === 'card';
       const hasParameters = this.rawViewMetadata.config?.parameters;
-      // @ts-ignore
       const isDeferDataPageCallEnabled = isCardVariant && hasParameters && !this.firstChildPConnect()?.getSharedDataPageForReferenceList();
 
       const useDropDownDataSource = (isCardVariant && (this.dropDownDataSource || isDeferDataPageCallEnabled)) || (!isCardVariant && hasParameters);

packages/angular-sdk-components/src/lib/_components/template/data-reference/search-form/tabsData.ts

@@ -127,7 +127,6 @@ export function getData(deferLoadedTabs, tabCountSources, currentTabId, data) {
       });
   } else if (calculatedFieldsWithoutValue.length) {
     PCore.getViewRuleApi()
-      // @ts-ignore
       .getCalculatedFields(
         pConn.getCaseInfo().getKey(),
         pConn.getCurrentView(),

packages/angular-sdk-components/src/lib/_components/template/field-group-template/field-group-template.component.ts

@@ -132,8 +132,7 @@ export class FieldGroupTemplateComponent implements OnInit, OnDestroy, OnChanges
     }
 
     if (this.referenceListLength() != referenceList?.length) {
-      // @ts-ignore - Expected 3 arguments, but got 1
-      this.pConn$.getListActions().initDefaultPageInstructions(resolvedList);
+      this.pConn$.getListActions().initDefaultPageInstructions(resolvedList, []);
 
       this.children = referenceList?.map((item, index) => {
         return {

packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/simple-table-manual.component.ts

@@ -464,7 +464,6 @@ export class SimpleTableManualComponent implements OnInit, OnDestroy {
     if (typeof allowRowDelete === 'string' && allowRowDelete.startsWith('@E ')) {
       try {
         const expression = allowRowDelete.replace('@E ', '');
-        // @ts-expect-error - options param is optional per corejs docs
         return PCore.getExpressionEngine().evaluate(expression, row);
       } catch {
         return true;

packages/angular-sdk-components/src/lib/_components/template/wss-nav-bar/wss-nav-bar.component.ts

@@ -27,7 +27,7 @@ export class WssNavBarComponent implements OnInit, OnDestroy {
   @Input() pages$: any[];
   @Input() caseTypes$: any[];
   @Input() homePage: any;
-  @Input() portalLogoImage$: string;
+  @Input() portalLogoImage$: string | Blob | null;
 
   // For interaction with AngularPConnect
   angularPConnectData: AngularPConnectData = {};

packages/angular-sdk-components/src/lib/_types/pcore-globals.d.ts

@@ -0,0 +1,10 @@
+import type PCoreInstance from '@pega/pcore-pconnect-typedefs';
+import type { C11nEnv } from '@pega/pcore-pconnect-typedefs/interpreter/c11n-env';
+
+declare global {
+  var PCore: PCoreInstance;
+  var PConnect: C11nEnv;
+  function getPConnect(): C11nEnv;
+}
+
+export {};

packages/angular-sdk-components/src/public-api.ts

@@ -2,6 +2,8 @@
  * Public API Surface of angular-sdk-components
  */
 
+import type {} from './lib/_types/pcore-globals';
+
 export * from './sdk-local-component-map';
 
 export * from './lib/_bridge/component-mapper/component-mapper.component';