feat: -sort orders inspect layouts by struct size#37
Open
peczenyj wants to merge 2 commits into
Open
Conversation
-sort (default off) collects findings across all scanned packages and presents them largest-first by absolute bytes saved (OldSize-NewSize), using a stable sort so equal-savings structs keep source order and unknown-size findings sink to the bottom. Diff mode only for now; inspect support follows. Part of #30 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
In -inspect mode, -sort now collects all layouts across packages and orders them largest-first by Layout.Total (stable sort). Updates the flag help to cover both modes. Diff behavior unchanged. Closes #30 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/sort-diff #37 +/- ##
=====================================================
+ Coverage 85.45% 85.55% +0.10%
=====================================================
Files 10 10
Lines 708 713 +5
=====================================================
+ Hits 605 610 +5
Misses 65 65
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
-sort(added for diff in #36) to inspect mode: layouts across all scanned packages are collected and ordered largest-first byLayout.Total(stable sort). Help text now reads "diff: by bytes saved; inspect: by struct size". Diff behavior is unchanged.While testing this I found that inspect's default order is alphabetical (
layout.Layoutsdoessort.Strings), so the test fixture usesAlpha(24B) /Zeta(40B) where alphabetical and size-descending genuinely differ — otherwise the sort would be untestable.Tests:
-inspect -sortrenders the larger struct first; default inspect order (alphabetical) is unchanged.task cigreen (91 tests).Closes #30
🤖 Generated with Claude Code