It grew into a gem #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ditched erb in favor of haml
* Added Jeweler so we can start building gems
Now supplying bin/vpnmaker
Author
|
Indeed, you're right on every account, i mean the comments. I'll be cleaning it up in the next few weeks. Being a noob, i really appreciate the input and if you have a few suggestions to pass along, please by all means! |
Owner
|
Thanks again for doing all this work, by the way. A lot of the changes make sense; there's just a bunch of places where it could be made somewhat cleaner. |
- added console to the rake task (not working yet) - made a templates directory for the haml files - made an examples directory
Due to the way we load the HAML templates using fakefs means that VPNMaker won't find the templates
also replaced string concats with File.join
getting so confused thinking self.generate is initialize....
data leakage what?
Testing is cool
Jeweler to bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't know if that was ever the intent, but now vpnmaker sports a cli and is wrapped in a gem... go figure...