tests: isolate temporary module commands from GO111MODULE#610
Open
HNO3Miracle wants to merge 1 commit into
Open
tests: isolate temporary module commands from GO111MODULE#610HNO3Miracle wants to merge 1 commit into
HNO3Miracle wants to merge 1 commit into
Conversation
Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 283 283
Lines 34456 34456
=======================================
Hits 34382 34382
Misses 46 46
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator round-trip tests intentionally create temporary Go modules, but their
go runsubprocesses inheritGO111MODULE=offfrom the caller. Explicitly enable module mode for those subprocesses, alongside the existingGOWORK=offandGOFLAGS=-mod=mod, so the test behavior matches its temporary-module setup.Testing:
go test ./generator/golangGO111MODULE=off; both pass.