fix: guard composed ref walker against odd-length mapping content (#607)#608
Open
SAY-5 wants to merge 1 commit into
Open
fix: guard composed ref walker against odd-length mapping content (#607)#608SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…33f#607) Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 283 283
Lines 34456 34459 +3
=======================================
+ Hits 34382 34385 +3
Misses 46 46
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BundleBytesComposedpanics withindex out of rangewhen a $ref resolves to an array with an odd number of elements (for example a root-leveltagslist that arrives as a mapping-tagged node during composition).walkAndRewriteRefssteps through a MappingNode's content two at a time assuming key/value pairs and readsContent[i+1], which is out of bounds when the length is odd. This adds a bounds check: if the final key has no paired value, the dangling node is walked directly instead of indexing past the end. Even-length arrays are unaffected. Repro and fix verified against the reproduction in #607, and the fullbundlersuite plusgo test ./...pass.