Flake toolchain and check improvements #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 20148305830Details
💛 - Coveralls |
Collaborator
|
uTack should we build the crate packages with the msrv toolchain instead of stable? |
benalleng
approved these changes
Dec 11, 2025
Collaborator
Author
yeah i guess that makes more sense |
2 tasks
nothingmuch
force-pushed
the
flake-toolchain-and-check-improvements
branch
from
7c53aa6 to
e71e464
Compare
Collaborator
Author
|
@benalleng @Mshehu5 i think it makes sense to rebase #1221 and #1224 on top of these changes, this will generate conflicts esp with #1221 (sorry Ben, i do think this refactoring will simplify some of that too though, and i didn't want to pull the treefmt changes into this already pretty big PR), but also it cleans up caching and makes it easier to run specific things with #1224 |
nothingmuch
force-pushed
the
flake-toolchain-and-check-improvements
branch
from
e71e464 to
f3a548c
Compare
- Cargo.lock is chosen based on the toolchain, minimal for msrv and recent for everything else - all cargoArtifacts reuse is now explicit - no more top level craneLib - crate packages are built using msrv toolchain
- quick - formatting - slow - all rust toolchain dependent checks, for all toolchains - nightly - rust-toolchain.toml based toolchain tests - stable - rust-overlay's default stable toolchain tests - crane packages - msrv - rust 1.85.0 toolchain tests
nothingmuch
force-pushed
the
flake-toolchain-and-check-improvements
branch
from
f3a548c to
0150ec8
Compare
Collaborator
Author
|
rebased on master |
benalleng
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.