Skip to content

fix(BulkSelect): more compact layout to match design #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(BulkSelect): more compact layout to match design #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfc7bee
fix(BulkSelect): more compact layout to match design
nicolethoen Nov 7, 2025
22f9a0b
fix lint
nicolethoen Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,5 +86,6 @@
"@patternfly/react-drag-drop": "^6.0.0",
"@patternfly/react-tokens": "^6.0.0",
"sharp": "^0.34.0"
}
},
"packageManager": "yarn@4.10.3+sha512.c38cafb5c7bb273f3926d04e55e1d8c9dfa7d9c3ea1f36a4868fa028b9e5f72298f0b7f401ad5eb921749eb012eb1c3bb74bf7503df3ee43fd600d14a018266f"
}
13 changes: 7 additions & 6 deletions packages/module/src/BulkSelect/BulkSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,13 @@ export const BulkSelect: FC<BulkSelectProps> = ({
}
onChange={(checked) => onSelect?.(!checked || checked === null ? noneOption : allOption)}
{...menuToggleCheckboxProps}
/>,
selectedCount > 0 ? (
<span onClick={onToggleClick} data-ouia-component-id={`${ouiaId}-text`} key="bulk-select-text">
{`${selectedCount} selected`}
</span>
) : null
>
{selectedCount > 0 ? (
<span data-ouia-component-id={`${ouiaId}-text`}>
{`${selectedCount} selected`}
</span>
) : null}
</MenuToggleCheckbox>
]}
/>
)}
Expand Down
36 changes: 24 additions & 12 deletions packages/module/src/BulkSelect/__snapshots__/BulkSelect.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ exports[`BulkSelect component should render 1`] = `
class="pf-v6-c-menu-toggle pf-m-split-button"
>
<label
class="pf-v6-c-check pf-m-standalone"
class="pf-v6-c-check"
>
<input
aria-invalid="false"
Expand All @@ -21,12 +21,18 @@ exports[`BulkSelect component should render 1`] = `
name="BulkSelect-checkbox"
type="checkbox"
/>
<span
aria-hidden="true"
class="pf-v6-c-check__label"
id="BulkSelect-checkbox"
>
<span
data-ouia-component-id="BulkSelect-text"
>
2 selected
</span>
</span>
</label>
<span
data-ouia-component-id="BulkSelect-text"
>
2 selected
</span>
<button
aria-expanded="false"
aria-label="Bulk select toggle"
Expand Down Expand Up @@ -66,7 +72,7 @@ exports[`BulkSelect component should render 1`] = `
class="pf-v6-c-menu-toggle pf-m-split-button"
>
<label
class="pf-v6-c-check pf-m-standalone"
class="pf-v6-c-check"
>
<input
aria-invalid="false"
Expand All @@ -78,12 +84,18 @@ exports[`BulkSelect component should render 1`] = `
name="BulkSelect-checkbox"
type="checkbox"
/>
<span
aria-hidden="true"
class="pf-v6-c-check__label"
id="BulkSelect-checkbox"
>
<span
data-ouia-component-id="BulkSelect-text"
>
2 selected
</span>
</span>
</label>
<span
data-ouia-component-id="BulkSelect-text"
>
2 selected
</span>
<button
aria-expanded="false"
aria-label="Bulk select toggle"
Expand Down
Loading