Skip to content

chore(CalendarMonth): Include OUIAProps for CalendarMonth - #12593

Merged
rebeccaalpert merged 1 commit into
patternfly:mainfrom
mshriver:calendar-month-ouia
Aug 10, 2026
Merged

chore(CalendarMonth): Include OUIAProps for CalendarMonth#12593
rebeccaalpert merged 1 commit into
patternfly:mainfrom
mshriver:calendar-month-ouia

Conversation

@mshriver

@mshriver mshriver commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Add OUIA attribute support to CalendarMonth for better test automation.

What:
Closes #12592

Summary by CodeRabbit

  • New Features
    • Added Open UI Automation support to the Calendar Month component.
    • Added optional automation properties for a custom component ID and safety behavior, enabled by default.
    • Included component type, custom ID, and safety state in rendered automation metadata.
  • Tests
    • Added coverage for Open UI Automation attributes and default behavior.
  • Documentation
    • Listed Calendar Month as a supported component in the Open UI Automation guide.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f2d96d9a-f36c-467e-8eb8-04b5fbe22f42

📥 Commits

Reviewing files that changed from the base of the PR and between 9d9253c and 26eea4a.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • packages/react-core/src/helpers/OUIA/OUIA.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-core/src/helpers/OUIA/OUIA.md

Walkthrough

CalendarMonth now accepts OUIA props, renders the corresponding data-ouia-* attributes, includes attribute tests, and is listed in the OUIA developer guide.

Changes

CalendarMonth OUIA integration

Layer / File(s) Summary
OUIA props and root rendering
packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx
CalendarMonth accepts ouiaId and ouiaSafe, computes OUIA props, and applies them to its root element.
OUIA validation and documentation
packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx, packages/react-core/src/helpers/OUIA/OUIA.md
Tests verify the OUIA component ID, component type, default safety value, and explicit safety override. The guide lists CalendarMonth as supported.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: kmcfaul, thatblindgeye, rebeccaalpert

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the CalendarMonth OUIAProps enhancement, which is the primary change.
Linked Issues check ✅ Passed The changes add OUIA props, apply them to CalendarMonth, test the attributes, and document support as required by issue #12592.
Out of Scope Changes check ✅ Passed All reviewed changes support the linked issue by implementing, testing, and documenting CalendarMonth OUIA support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the snapshot test - any particular reason for it?

Comment thread packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx Outdated
@mshriver
mshriver force-pushed the calendar-month-ouia branch from 18d8c90 to 5bef644 Compare August 6, 2026 13:36
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@mshriver
mshriver requested a review from rebeccaalpert August 6, 2026 13:37

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than failing tests lgtm

@rebeccaalpert

Copy link
Copy Markdown
Member

Fixed out-of-date broken snapshots.

Add OUIA attribute support to CalendarMonth for better test automation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert

Copy link
Copy Markdown
Member

Rebased.

@rebeccaalpert
rebeccaalpert merged commit 0618a6b into patternfly:main Aug 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CalendarMonth missing OUIA Support

3 participants