feat(UserFeedback): updated compact style and added privacy statement #771
Conversation
|
Preview: https://chatbot-pr-chatbot-771.surge.sh A11y report: https://chatbot-pr-chatbot-771-a11y.surge.sh |
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
I'm not against this per se, but it is weird we have children and a privacy statement in the example and that they're so similar. My question would be where the line is - do we want to just use children? Or do we want to update the text in the demo instead?
.../module/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithFeedback.tsx
Outdated
Show resolved
Hide resolved
|
@rebeccaalpert updated the example so that the children content wasn't so privacy-statementy. Since the design kit issue asked for different styling on the privacy statement content, both could be valid depending on the use case I think. |
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
This is fine with me - y'all just may want to push back if folks come in wanting more custom styles. The children prop should take anything.
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
couple of small notes for the example microcopy, but nothing too crazy / holding things back
|
|
||
| const children = <>Do not share any personal or other sensitive information in your feedback.</>; | ||
| const children = <>This is additional content.</>; | ||
| const privacyStatement = 'This is a privacy statement text content.'; |
There was a problem hiding this comment.
| const privacyStatement = 'This is a privacy statement text content.'; | |
| const privacyStatement = 'Do not share any personal or other sensitive information in your feedback.'; |
this isn't necessary, but is the privacy statement intended to be similar to this bit we have in our current examples? If so, I'm just thinking it may be clearer what sort of content might belong here if we stick it as a more tangible example
| role="bot" | ||
| avatar={patternflyAvatar} | ||
| content="This is a message with the feedback card:" | ||
| content="This is a message with the feedback card" |
There was a problem hiding this comment.
| content="This is a message with the feedback card" | |
| content="This is a message with the feedback card:" |
just adding back to match the others
kaylachumley
left a comment
kaylachumley
left a comment
There was a problem hiding this comment.
get nit picky here, sorry.. is it possible to have the message icon and the close icon button to be horizontally inline with eachother instead of the close icon button being in its own row taking up the entire width of the card?
before:
after:
thatblindgeye
force-pushed
the
iss769_feedbackCompact
branch
from
4419727 to
78ac4dd
Compare
|
🎉 This PR is included in version 6.5.0-prerelease.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
Closes #769