Open
Conversation
|
This looks useful. |
vishnuvvn
approved these changes
Nov 2, 2017
kyroy
approved these changes
Dec 10, 2017
|
Could someone merge it? |
bgokden
approved these changes
Nov 14, 2020
orlinhristov
suggested changes
Mar 30, 2021
| } | ||
|
|
||
| func (c *cache) ExpireAt(k string, expire *time.Time) error { | ||
| c.Lock() |
There was a problem hiding this comment.
The defer c.Unlock() should be used here to automatically release the resource.
| c.Lock() | ||
| v, found := c.items[k] | ||
| if !found || v.Expired() { | ||
| c.Unlock() |
There was a problem hiding this comment.
This line should be removed if the defer c.Unlock() is used.
| } | ||
|
|
||
| v.Expiration = expire | ||
| c.Unlock() |
There was a problem hiding this comment.
This line should be removed if the defer c.Unlock() is used.
| delete(c.items, k) | ||
| } | ||
|
|
||
| func (c *cache) Expire(k string, d time.Duration) error { |
There was a problem hiding this comment.
To avoid code duplication I suggest to replace the method implementation with the following code:
func (c *cache) Expire(k string, d time.Duration) error {
e := time.Now().Add(d)
return c.ExpireAt(k, e)
}Also, I would rename this method to 'ExpireAfter'.
|
Found this fork: https://github.com/arp242/zcache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that it lacks of Expire and ExpireAt command and many others..