Skip to content

refactor: split into a VS Code-free core and fix sorting, comment and command bugs - #330

Merged
pascalre merged 18 commits into
masterfrom
feat/clean-architecture-refactor
Nov 20, 2026
Merged

pascalre merged 18 commits into
masterfrom
feat/clean-architecture-refactor

refactor(comments): move comment recognition into yaml-comment

5899f33
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 20, 2026 in 23s

Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 7 in src/core/processor/octal-processor.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Simplify this regular expression to reduce its complexity from 21 to the 20 allowed.

See more on https://sonarcloud.io/project/issues?id=pascalre_vscode-yaml-sort&issues=AaH5ZXa_fwzYga3HI1vM&open=AaH5ZXa_fwzYga3HI1vM&pullRequest=330

Check warning on line 1 in src/core/yaml-file-finder.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `node:path` over `path`.

See more on https://sonarcloud.io/project/issues?id=pascalre_vscode-yaml-sort&issues=AaH5ZXbffwzYga3HI1vN&open=AaH5ZXbffwzYga3HI1vN&pullRequest=330

Check warning on line 28 in src/core/sort-order.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Arguments 'b' and 'a' have the same names but not the same order as the function parameters.

See more on https://sonarcloud.io/project/issues?id=pascalre_vscode-yaml-sort&issues=AaH5ZXbrfwzYga3HI1vO&open=AaH5ZXbrfwzYga3HI1vO&pullRequest=330

Check warning on line 28 in .github/workflows/action.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Omitting "--ignore-scripts" allows lifecycle scripts to run during package installation.

See more on https://sonarcloud.io/project/issues?id=pascalre_vscode-yaml-sort&issues=AaH5ZXb3fwzYga3HI1vP&open=AaH5ZXb3fwzYga3HI1vP&pullRequest=330

Check warning on line 7 in src/core/processor/octal-processor.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Simplify this regular expression to reduce its runtime, as it has super-linear performance due to backtracking.

See more on https://sonarcloud.io/project/issues?id=pascalre_vscode-yaml-sort&issues=AaH5ZXa_fwzYga3HI1vL&open=AaH5ZXa_fwzYga3HI1vL&pullRequest=330

Check warning on line 28 in src/test/unit/core/yaml-sorter.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this test title to make it unique within the suite.

See more on https://sonarcloud.io/project/issues?id=pascalre_vscode-yaml-sort&issues=AaH5ZXXafwzYga3HI1vJ&open=AaH5ZXXafwzYga3HI1vJ&pullRequest=330

Check failure on line 100 in src/test/integration/editor-commands.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case.

See more on https://sonarcloud.io/project/issues?id=pascalre_vscode-yaml-sort&issues=AaH5ZXaPfwzYga3HI1vK&open=AaH5ZXaPfwzYga3HI1vK&pullRequest=330