Repository navigation
refactor(test): import Mocha as default export - #329
Merged
Merged
Conversation
DeepSource reported "Explicitly import the specific method needed" for the namespace import `import * as Mocha from "mocha"` in the test runner. A named import is not possible, because @types/mocha declares the module with `export = Mocha`. Import the class as default export and enable esModuleInterop. The generated helper returns the module's default export if it is an ES module namespace and the module itself otherwise, so the runner works whether VS Code loads mocha 12 as ES module (as Node 22 does) or as its CommonJS build. The previous `new Mocha()` on the result of require() only worked for the latter. esModuleInterop changes no other compiled file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jdb5is9YsMnteaxHryN26M
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
src/test/suite/index.ts:import * as Mocha from "mocha"replaced byimport Mocha from "mocha".tsconfig.json: enabledesModuleInterop.Why
DeepSource reported "Explicitly import the specific method needed" for the namespace import introduced in #328. A named import is not possible because
@types/mochadeclares the module withexport = Mocha.With
esModuleInterop, the generated__importDefaulthelper returns the module's default export if it is an ES module namespace, and the module itself otherwise. The runner therefore works whether VS Code loads mocha 12 as ES module (as Node 22 does) or as its CommonJS build. The previousnew Mocha()on the result ofrequire()only worked for the latter.Testing
out/before and after: onlyout/test/suite/index.jsdiffers, soesModuleInterophas no effect on the extension code.Mochainstance.tsc,eslint, dependency-cruiser and 207 tests pass locally.Generated by Claude Code