refactor(vscode): restructure extension architecture#299
Draft
hongjr03 wants to merge 17 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the VS Code extension architecture so the native and browser runtimes are separated by construction, with shared code limited to runtime-neutral contracts.
This includes:
src/nodesrc/browsersrc/nodeBrowserClientControllerto own browser client lifecycle, restart serialization, debounce, and stale-client guardsValidation
npm testfromeditors/vscodepassed: 63 testsnpm run bundle:browser:extensionfromeditors/vscodepassednpm run test:webis blocked in this local environment becauseplayground/public/wasmis missing; attemptingnpm --prefix playground run build:wasmfails becauseninjais not installed (spawnSync ninja ENOENT)