[minion] Disable GPG commit signing in test git repos#13
Open
[minion] Disable GPG commit signing in test git repos#13
Conversation
Automated by partio-io/minions (task: ci-gpg-signing-test-fix) Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Any test helper that initializes a temporary git repository for use in tests should explicitly disable GPG commit signing via
git config commit.gpgsign falseand pass--no-gpg-signto anygit commitcalls. This matches the pattern used in the project's canonicaltestutil.InitRepo(or equivalent) helper and prevents test failures in CI environments where GPG keys are not configured.Why
Tests that create git repos fail in CI environments (GitHub Actions, etc.) where GPG signing is enabled globally but no signing key is configured, causing intermittent and confusing CI failures.
Automated PR by partio-io/minions · Task:
ci-gpg-signing-test-fixCreated by an unattended coding agent. Please review carefully.