refactor: Bump express-rate-limit from 8.3.1 to 8.7.0 - #10661
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates ChangesDependency refresh
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dependency refresh has no identified merge-blocking behavior or installation risk. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10661 +/- ##
==========================================
- Coverage 93.82% 93.80% -0.02%
==========================================
Files 192 192
Lines 16863 16863
Branches 252 252
==========================================
- Hits 15821 15819 -2
- Misses 1020 1022 +2
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull Request
Issue
This PR replaces the original Dependabot pull request #10621, which is stale (it stopped at
8.6.2and automatic rebases have been disabled). Dependabot branches live in the upstream repository and cannot be modified directly, so the update is re-created here from a fork against currentalpha.Approach
Bumps the
express-rate-limitdependency from8.3.1to8.7.0.Parse Server uses
express-rate-limitinsrc/middlewares.jsto enforce therateLimitoption (and Cloud Code validators) with a customkeyGenerator(global / session / user / IP viarequest.config.ip) and an optional Redis store. This is a version-only bump: no Parse Server source, public API, or option schema changes.Upstream changes included in this bump (
8.3.2through8.7.0):8.7.0— added aretryAfteroption to override theRetry-Afterheader. Unused by Parse Server.8.6.2—ipKeyGeneratornow detects IPv4-mapped IPv6 addresses by range rather than formatting. Parse Server's customkeyGeneratordoes not callipKeyGenerator; it keys on app id, session token, user id, orrequest.config.ip.8.6.1— deprecated millisecond-based time constants (DAY,HOUR,MINUTE,SECOND). Parse Server does not use these constants.8.6.0— fixed a negativeusedcount whenskipSuccessfulRequests/skipFailedRequestsoverlap a window reset; added debug logging and time constants; validations now run once each instead of only on the first request. Parse Server does not use the skip-success/fail options.8.5.2— reduced string templating inipKeyGenerator.8.5.1— updated theip-addresstransitive dependency for GHSA-v2v4-37r5-5v8g.8.5.0— storeinitmay now be async. Compatible with the existing Redis store wiring.8.4.1— custom logger support. Unused; default logging is unchanged.8.3.2— fixed skipping failed requests for connections closed very early.The lockfile also resolves the
ip-addresstransitive dependency from10.1.0to10.7.0(required byexpress-rate-limit@8.7.0) and records npm's lockfile metadata refresh.No breaking changes are documented between
8.3.1and8.7.0.Tasks
8.3.1and8.7.0; none apply to this bump.spec/RateLimit.spec.js(52 passed, 1 pending Redis-cache spec that is skipped unlessPARSE_SERVER_TEST_CACHE=redis).No new tests and no documentation changes are required: this is a version-only bump and contains no changes to Parse Server source code, behaviour or public API.
Summary by CodeRabbit