Skip to content

fix: make HasProfileData an existence probe instead of a full-table scan #6402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javicj wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

fix: make HasProfileData an existence probe instead of a full-table scan #6402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions pkg/clickhouse/querier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,21 @@ func (q *Querier) ProfileTypes(

// HasProfileData checks if there is any profile data in the store.
func (q *Querier) HasProfileData(ctx context.Context) (bool, error) {
types, err := q.ProfileTypes(ctx, time.UnixMilli(0), time.UnixMilli(0))
ctx, span := q.tracer.Start(ctx, "ClickHouse/HasProfileData")
defer span.End()

// LIMIT 1 lets ClickHouse stop at the first granule instead of running
// the previous DISTINCT over the whole table.
rows, err := q.client.Query(ctx, fmt.Sprintf(`
SELECT 1 FROM %s
LIMIT 1
`, q.client.FullTableName()))
if err != nil {
return false, err
return false, fmt.Errorf("failed to query profile data existence: %w", err)
}
return len(types) > 0, nil
defer rows.Close()

return rows.Next(), rows.Err()
}

// QueryRange executes a range query and returns time series data.
Expand Down