ui: Flamechart improvements #6087
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces useAutoFlameChartQuerySelector to automatically configure query parameters when the flame chart dashboard item is added.
|
✅ Meticulous spotted visual differences in 116 of 336 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~4 hours of user flows against your PR. Last updated for commit 61b2429. This comment will update as new commits are pushed. |
Member
|
interesting .. should we maybe make flamecharts a top-level tab? I find the UX of the visualization selection changing the previous, further up selections quite unexpected |
yomete
force-pushed
the
flamechart-improvements
branch
from
d25bede to
5b27526
Compare
This allows updating the sumBy value when committing a draft.
yomete
force-pushed
the
flamechart-improvements
branch
from
c6f28c7 to
8bb6a9b
Compare
yomete
force-pushed
the
flamechart-improvements
branch
from
5b7c41b to
b18049d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an auto-configuration feature for the flame chart, providing users with a one-click way to optimize their view and an explanatory popover when auto-configuration occurs.
Flame chart auto-configuration and popover:
FLAMECHART_AUTO_CONFIG_POPOVER_DISMISSEDto allow users to dismiss the auto-configuration popover and remember their choice.FlameChartAutoConfigPopovercomponent that explains which settings were auto-configured for optimal viewing and allows users to dismiss it.useAutoConfigureFlamecharthook, which updates URL state to set optimal flame chart parameters (time range, sum-by labels, etc.) and signals when auto-configuration occurs.