Refresh the wiki's screenshots from the running app, and get the last Settings row out from under the navigation bar

[parawanderer]

The wiki's images came from several phones over several years, and nothing recorded how any of them was taken. This makes them reproducible, and fixes the things that turned up while doing it.

The fix worth reviewing

The last row of Settings sat under the navigation bar. The theme makes it transparent, so the scrolling area runs underneath, and the debug switch is last with nothing below it.

Measured on a Pixel 9 emulator, scrolled all the way down: the switch ended at 2350 with the bar starting at 2361. Eleven pixels, on gesture navigation. Three-button navigation asks for around 126px instead of 63, and those eleven pixels become a switch nobody can tap.

The scroll area now reserves the measured inset, and clipToPadding="false" makes that space scrollable rather than a strip that clips the rows passing through it. No new dimension — the child already leaves 20dp under its content, which is the visual gap; what was missing was the bar's own space.

The test asserts the reserved space as well as the geometry, and the reserved space is the half that bites. A purely geometric assertion is green with the fix removed, because of those eleven pixels — it would only fail on a device this suite never runs on. Checked both ways: passes with the fix, fails without it with reserves 0px, needs 63px.

A real bug in a shared fixture

AMapWithTagsOnIt.putItBack had guard.restore() last in a plain sequence, so a test that failed hard enough to upset the scenario close or the Python double took the settings and the stored session down with it. The next class then met somebody signed in who should not have been, and failed with NoActivityResumedException — nowhere near anything mentioning a session. It is in a finally now. This affects every test using that fixture, not only the new ones.

The captures themselves

Three classes covering 21 screens: the iCloud import route, the export flow, signing in, Settings and its dialogs, and turning on debug data to get a log out.

They are skipped unless asked for. Each ends in a Shot and asserts almost nothing, so a green run of them says nothing about the app — and they added about twenty minutes to a suite people are meant to run constantly. Same opt-in mechanism as the Anisette live tests:

ANDROID_SERIAL=emulator-5554 ./gradlew :app:connectedDebugAndroidTest \
  -Pandroid.testInstrumentationRunnerArguments.captureScreenshots=true \
  -Pandroid.testInstrumentationRunnerArguments.class=dev.wander.android.opentagviewer.ui.WikiScreenshotsTest

Everything on them is fabricated except the map: the session, the tags, the locations, the phone numbers and the address. The pin is the Eiffel Tower and the geocoder answers "a made-up street, in a made-up town".

blur.py takes bands out of a screenshot by height fraction, for the AMap key dialog — it prints the build's own package name and signing fingerprint, which is exactly what AMap's console asks you to paste, and not something to put on a public page.

Two things measured rather than guessed, now in CONTRIBUTING

• The map captures are slow, and it is the teardown. ~50s per test, of which ~45s is putItBack; setup is about two seconds. Recorded because the real Google map, the dialog waits and the tile sleep all look guilty and none of them is — I chased all three before measuring.
• A PR stacked on another PR runs no checks at all. Every workflow filters pull_request: branches: ["main"], and that matches the base. The checks section is absent rather than red or pending, which reads as "nothing to run here" instead of "nothing ran". Re-read the account when somebody would notice, and explain the device once #153 sat like that.

Verified

• JVM suite green; translation check green (301 strings, 9 locales)
• The padding test run both with and without the fix, confirming it can fail
• All 21 captures produced on a windowed Pixel 9 emulator
• Confirmed the capture classes now skip by default: that class went from six minutes to 14 seconds

Not verified: any physical device, and any navigation mode other than this emulator's gesture bar — the three-button figure above is Android's documented size, not something I measured here.

🤖 Generated with Claude Code