Show Apple's terms of service in the wizard, instead of stopping at them

[parawanderer]

The CLI has handled pending iCloud terms since the iCloud route landed. The window could not: it stopped at a MobileMeDelegateError with no way past it. Apple takes acceptance on one of its own devices or at icloud.com and nowhere else, so somebody with neither — which is everyone this project is for — was stuck.

What it does

Same trigger as the CLI. Each document is rendered through exporter.terms, which the CLI already uses, and shown in a modal with Accept and Reject. Acceptance is sent only for documents that were accepted, then complete_login() runs — without which the account is left at AUTHENTICATED: readable, and unusable for everything after it.

Reject closes the exporter. That is the one exception to _load's rule that nothing closes the window from here, and it is deliberate — every other failure leaves the button there because trying again might work, and this one cannot, since the same document is waiting on the next attempt. It says nothing was sent, that the account is unchanged, and where else terms can be accepted.

One deliberate difference from the CLI

The CLI asks "Fetch the terms of service?" first, because it is about to page a document at a terminal and cannot take that back. Here the fetch is what decides whether there is anything to show, so asking first would mean offering to look and then reporting there was nothing. A delegate failure with no terms pending reports what Apple said, unchanged, rather than describing the check.

Testing

28 tests — 13 for the flow with the dialog stubbed, needing no display, and 15 driving the real window.

Building the dialog and showing it are separate functions so that it can be tested at all. grab_set plus wait_window hand control to a nested event loop and a window manager, and a test that schedules a click into that deadlocks rather than failing — which is what the first version of this did.

For the same reason keyboard bindings are asserted with widget.bind rather than pressed: a Toplevel under a withdrawn root holds focus from nobody, so event_generate is dropped in silence and "press Return, assert nothing happened" passes just as well when the key never arrived. That one passed once and failed on the next run, which is how it was noticed.

Verified by breaking seven things on purpose, each of which reddens the tests that exist for it:

Mutation	Tests reddened
An unanswered dialog counts as agreement	2
Drop complete_login	2
Send acceptance before asking	3
Leave the terms box editable	1
Bind Return to Accept	1
Reject leaves the window open	1
Reject routed through the "please file a bug" handler	1

Not verified against Apple. The trigger needs an account with terms actually pending, which cannot be produced on demand and which nobody here has. The flow tests drive a fake account.

Also

CONTRIBUTING.md said two files need Tk. It was already three before this and is now four, so that became a table, along with the two traps above.

---

PR description summarised by Claude Code.